OpenC3/cosmos

Method to_config has 67 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def to_config(cmd_or_tlm, default_endianness)
      config = ''
      if cmd_or_tlm == :TELEMETRY
        if self.array_size
          config << "  ARRAY_ITEM #{self.name.to_s.quote_if_necessary} #{self.bit_offset} #{self.bit_size} #{self.data_type} #{self.array_size} \"#{self.description.to_s.gsub("\"", "'")}\""

Method as_json has 66 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def as_json(*a)
      config = {}
      config['name'] = self.name
      config['bit_offset'] = self.bit_offset
      config['bit_size'] = self.bit_size

Method from_json has 55 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def self.from_json(hash)
      # Convert strings to symbols
      endianness = hash['endianness'] ? hash['endianness'].intern : nil
      data_type = hash['data_type'] ? hash['data_type'].intern : nil
      overflow = hash['overflow'] ? hash['overflow'].intern : nil

Method to_hash has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def to_hash
      hash = super()
      hash['format_string'] = self.format_string
      if self.read_conversion
        hash['read_conversion'] = self.read_conversion.to_s

Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def initialize(name, bit_offset, bit_size, data_type, endianness, array_size = nil, overflow = :ERROR)

Avoid deeply nested control flow statements.

Open

              raise ArgumentError, "#{@name}: maximum must be a Float but is a #{@range.last.class}" unless Float === @range.last or Integer === @range.last

Avoid deeply nested control flow statements.

Open

              raise ArgumentError, "#{@name}: maximum must be a Integer but is a #{@range.last.class}" unless Integer === @range.last

Avoid deeply nested control flow statements.

Open

              raise ArgumentError, "#{@name}: minimum must be a Integer but is a #{@range.first.class}" unless Integer === @range.first

Avoid deeply nested control flow statements.

Open

              raise ArgumentError, "#{@name}: minimum must be a Float but is a #{@range.first.class}" unless Float === @range.first or Integer === @range.first

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      if hash['read_conversion']
        begin
          item.read_conversion = OpenC3::const_get(hash['read_conversion']['class']).new(*hash['read_conversion']['params'])
        rescue => error
          Logger.instance.error "#{item.name} read_conversion of #{hash['read_conversion']} could not be instantiated due to #{error}"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      if hash['write_conversion']
        begin
          item.write_conversion = OpenC3::const_get(hash['write_conversion']['class']).new(*hash['write_conversion']['params'])
        rescue => error
          Logger.instance.error "#{item.name} write_conversion of #{hash['write_conversion']} could not be instantiated due to #{error}"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          config << "  ARRAY_ITEM #{self.name.to_s.quote_if_necessary} #{self.bit_offset} #{self.bit_size} #{self.data_type} #{self.array_size} \"#{self.description.to_s.gsub("\"", "'")}\""

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          config << "  ARRAY_PARAMETER #{self.name.to_s.quote_if_necessary} #{self.bit_offset} #{self.bit_size} #{self.data_type} #{self.array_size} \"#{self.description.to_s.gsub("\"", "'")}\""

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def read_conversion=(read_conversion)
      if read_conversion
        raise ArgumentError, "#{@name}: read_conversion must be a OpenC3::Conversion but is a #{read_conversion.class}" unless OpenC3::Conversion === read_conversion or OpenC3::PythonProxy === read_conversion

        @read_conversion = read_conversion.clone

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def write_conversion=(write_conversion)
      if write_conversion
        raise ArgumentError, "#{@name}: write_conversion must be a OpenC3::Conversion but is a #{write_conversion.class}" unless OpenC3::Conversion === write_conversion or OpenC3::PythonProxy === write_conversion

        @write_conversion = write_conversion.clone

• Read up
  Read up