Sign upLogin

OpenHPS/openhps-core

View on GitHub
Star
src/worker/WorkerHandler.ts

Summary

Maintainability
C
1 day
Test Coverage

File WorkerHandler.ts has 277 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { BlobWorker, Pool, spawn, Thread, Worker } from 'threads';
import { PoolEvent } from 'threads/dist/master/pool';
import { Observable } from 'threads/observable';
import { DataFrame } from '../data/DataFrame';
import { DataSerializer } from '../data/DataSerializer';
Severity: Minor
Found in src/worker/WorkerHandler.ts - About 2 hrs to fix

    Function _spawnWorker has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private _spawnWorker(): Promise<Thread> {
        return new Promise((resolve, reject) => {
            const worker = this.createWorker();
            spawn(worker, {
                timeout: this.options.timeout,
    Severity: Minor
    Found in src/worker/WorkerHandler.ts - About 1 hr to fix

      Function _onWorkerService has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private _onWorkerService(threadId: number, value: WorkerServiceCall): void {
        const service: Service =
            this.model.findDataService(value.serviceUID) || this.model.findService(value.serviceUID);
        if ((service as any)[value.method]) {
            const serializedParams = value.parameters;
      Severity: Minor
      Found in src/worker/WorkerHandler.ts - About 1 hr to fix

        Function _addServices has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private _addServices(services: any[], call: (call: WorkerServiceCall) => Promise<WorkerServiceResponse>): void {
        const model = this.model as ModelGraph<any, any>;
        services
            .filter((service) => {
                const internalService =
        Severity: Minor
        Found in src/worker/WorkerHandler.ts - About 1 hr to fix

          Function createWorker has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected createWorker(): Worker {
        if (this.options.blob) {
            const worker = new BlobWorker(this.options.worker as any, {
                type: this.options.type === 'typescript' ? 'classic' : this.options.type,
            });
          Severity: Minor
          Found in src/worker/WorkerHandler.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _getServices has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private _getServices(): any[] {
        // Serialize this model services to the worker
        const services: Service[] = this.options.services || this.model.findAllServices();
        const servicesArray: any[] = services.map((service) => {
            // Services are wrapped in a proxy. Get prototype
          Severity: Minor
          Found in src/worker/WorkerHandler.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      serializedParams.forEach((param: any) => {
                if (param['__type']) {
                    params.push(DataSerializer.deserialize(param));
                } else {
                    params.push(param);
          Severity: Major
          Found in src/worker/WorkerHandler.ts and 1 other location - About 1 hr to fix
          src/worker/WorkerBase.ts on lines 233..239

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  const service: Service =
            this.model.findDataService(value.serviceUID) || this.model.findService(value.serviceUID);
          Severity: Minor
          Found in src/worker/WorkerHandler.ts and 1 other location - About 40 mins to fix
          src/worker/WorkerBase.ts on lines 228..229

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status