Sign upLogin

OpenHPS/openhps-solid

View on GitHub
Star
src/browser/SolidClientService.ts

Summary

Maintainability
D
2 days
Test Coverage

Function handleRedirect has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected async handleRedirect(session?: SolidSession): Promise<ISessionInfo> {
        try {
            const url = new URL(window.location.href);
            // Check if can process
            if (url.searchParams.get('code') === null && url.searchParams.get('state') === null) {
Severity: Major
Found in src/browser/SolidClientService.ts - About 4 hrs to fix

    File SolidClientService.ts has 258 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { ISessionInfo, ISessionOptions, IStorage, Session } from '@inrupt/solid-client-authn-browser';
import { SolidProfileObject } from '../common';
import { SolidService, SolidDataServiceOptions, SolidSession, ISessionInternalInfo } from '../common/SolidService';
import {
    buildAuthenticatedFetch,
    Severity: Minor
    Found in src/browser/SolidClientService.ts - About 2 hrs to fix

      Function handleLogin has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          handleLogin(): Promise<SolidSession> {
        return new Promise((resolve, reject) => {
            let storedSessionData: ISessionInfo & ISessionInternalInfo = undefined;
            let session: SolidSession = undefined;
            let sessionId: string = undefined;
      Severity: Major
      Found in src/browser/SolidClientService.ts - About 2 hrs to fix

        Function handleRedirect has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            protected async handleRedirect(session?: SolidSession): Promise<ISessionInfo> {
        try {
            const url = new URL(window.location.href);
            // Check if can process
            if (url.searchParams.get('code') === null && url.searchParams.get('state') === null) {
        Severity: Minor
        Found in src/browser/SolidClientService.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                    return undefined;
        Severity: Major
        Found in src/browser/SolidClientService.ts - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              logout(session: SolidSession): Promise<void> {
        return new Promise((resolve, reject) => {
            session
                .logout()
                .then(() => {
          Severity: Major
          Found in src/browser/SolidClientService.ts and 1 other location - About 4 hrs to fix
          src/node/SolidClientService.ts on lines 55..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 117.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              const authFetch = await buildAuthenticatedFetch(fetch, tokens.accessToken, {
                        dpopKey: tokens.dpopKey,
                        refreshOptions: undefined,
                        eventEmitter: undefined,
                        expiresIn: tokens.expiresIn,
          Severity: Minor
          Found in src/browser/SolidClientService.ts and 1 other location - About 40 mins to fix
          src/browser/SolidClientService.ts on lines 250..255

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      const authFetch = await buildAuthenticatedFetch(fetch, tokens.accessToken, {
                dpopKey: tokens.dpopKey,
                refreshOptions: undefined,
                eventEmitter: undefined,
                expiresIn: tokens.expiresIn,
          Severity: Minor
          Found in src/browser/SolidClientService.ts and 1 other location - About 40 mins to fix
          src/browser/SolidClientService.ts on lines 172..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status