OpenHPS/openhps-sphero

View on GitHub

Showing 37 of 37 total issues

Function sensorValuesToRawV2 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

const sensorValuesToRawV2 = (
  sensorMask: SensorMaskValues[],
  apiVersion: APIVersion = APIVersion.V2
) =>
  sensorMask.reduce((v2, m) => {
Severity: Minor
Found in lib/web/src/toys/utils.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public something1(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.systemInfo.something());
  }
Severity: Major
Found in lib/web/src/toys/sphero-mini.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/core.ts on lines 169..171
lib/web/src/toys/r2d2.ts on lines 15..17
lib/web/src/toys/r2d2.ts on lines 18..20
lib/web/src/toys/sphero-mini.ts on lines 19..21
lib/web/src/toys/sphero-mini.ts on lines 23..25
lib/web/src/toys/sphero-mini.ts on lines 27..29
lib/web/src/toys/sphero-mini.ts on lines 31..33
lib/web/src/toys/sphero-mini.ts on lines 35..37
lib/web/src/toys/sphero-mini.ts on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public something4(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.power.something4());
  }
Severity: Major
Found in lib/web/src/toys/sphero-mini.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/core.ts on lines 169..171
lib/web/src/toys/r2d2.ts on lines 15..17
lib/web/src/toys/r2d2.ts on lines 18..20
lib/web/src/toys/sphero-mini.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 19..21
lib/web/src/toys/sphero-mini.ts on lines 23..25
lib/web/src/toys/sphero-mini.ts on lines 31..33
lib/web/src/toys/sphero-mini.ts on lines 35..37
lib/web/src/toys/sphero-mini.ts on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public something5(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.somethingApi.something5());
  }
Severity: Major
Found in lib/web/src/toys/sphero-mini.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/core.ts on lines 169..171
lib/web/src/toys/r2d2.ts on lines 15..17
lib/web/src/toys/r2d2.ts on lines 18..20
lib/web/src/toys/sphero-mini.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 19..21
lib/web/src/toys/sphero-mini.ts on lines 23..25
lib/web/src/toys/sphero-mini.ts on lines 27..29
lib/web/src/toys/sphero-mini.ts on lines 35..37
lib/web/src/toys/sphero-mini.ts on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public something6(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.systemInfo.something6());
  }
Severity: Major
Found in lib/web/src/toys/sphero-mini.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/core.ts on lines 169..171
lib/web/src/toys/r2d2.ts on lines 15..17
lib/web/src/toys/r2d2.ts on lines 18..20
lib/web/src/toys/sphero-mini.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 19..21
lib/web/src/toys/sphero-mini.ts on lines 23..25
lib/web/src/toys/sphero-mini.ts on lines 27..29
lib/web/src/toys/sphero-mini.ts on lines 31..33
lib/web/src/toys/sphero-mini.ts on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public sleep(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.power.sleep());
  }
Severity: Major
Found in lib/web/src/toys/r2d2.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/core.ts on lines 169..171
lib/web/src/toys/r2d2.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 19..21
lib/web/src/toys/sphero-mini.ts on lines 23..25
lib/web/src/toys/sphero-mini.ts on lines 27..29
lib/web/src/toys/sphero-mini.ts on lines 31..33
lib/web/src/toys/sphero-mini.ts on lines 35..37
lib/web/src/toys/sphero-mini.ts on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public something3(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.power.something3());
  }
Severity: Major
Found in lib/web/src/toys/sphero-mini.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/core.ts on lines 169..171
lib/web/src/toys/r2d2.ts on lines 15..17
lib/web/src/toys/r2d2.ts on lines 18..20
lib/web/src/toys/sphero-mini.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 19..21
lib/web/src/toys/sphero-mini.ts on lines 27..29
lib/web/src/toys/sphero-mini.ts on lines 31..33
lib/web/src/toys/sphero-mini.ts on lines 35..37
lib/web/src/toys/sphero-mini.ts on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public wake(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.power.wake());
  }
Severity: Major
Found in lib/web/src/toys/r2d2.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/core.ts on lines 169..171
lib/web/src/toys/r2d2.ts on lines 18..20
lib/web/src/toys/sphero-mini.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 19..21
lib/web/src/toys/sphero-mini.ts on lines 23..25
lib/web/src/toys/sphero-mini.ts on lines 27..29
lib/web/src/toys/sphero-mini.ts on lines 31..33
lib/web/src/toys/sphero-mini.ts on lines 35..37
lib/web/src/toys/sphero-mini.ts on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public something2(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.power.something2());
  }
Severity: Major
Found in lib/web/src/toys/sphero-mini.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/core.ts on lines 169..171
lib/web/src/toys/r2d2.ts on lines 15..17
lib/web/src/toys/r2d2.ts on lines 18..20
lib/web/src/toys/sphero-mini.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 23..25
lib/web/src/toys/sphero-mini.ts on lines 27..29
lib/web/src/toys/sphero-mini.ts on lines 31..33
lib/web/src/toys/sphero-mini.ts on lines 35..37
lib/web/src/toys/sphero-mini.ts on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public something7(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.systemInfo.something7());
  }
Severity: Major
Found in lib/web/src/toys/sphero-mini.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/core.ts on lines 169..171
lib/web/src/toys/r2d2.ts on lines 15..17
lib/web/src/toys/r2d2.ts on lines 18..20
lib/web/src/toys/sphero-mini.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 19..21
lib/web/src/toys/sphero-mini.ts on lines 23..25
lib/web/src/toys/sphero-mini.ts on lines 27..29
lib/web/src/toys/sphero-mini.ts on lines 31..33
lib/web/src/toys/sphero-mini.ts on lines 35..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  public enableCollisionDetection(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.sensor.enableCollisionAsync());
  }
Severity: Major
Found in lib/web/src/toys/core.ts and 9 other locations - About 35 mins to fix
lib/web/src/toys/r2d2.ts on lines 15..17
lib/web/src/toys/r2d2.ts on lines 18..20
lib/web/src/toys/sphero-mini.ts on lines 15..17
lib/web/src/toys/sphero-mini.ts on lines 19..21
lib/web/src/toys/sphero-mini.ts on lines 23..25
lib/web/src/toys/sphero-mini.ts on lines 27..29
lib/web/src/toys/sphero-mini.ts on lines 31..33
lib/web/src/toys/sphero-mini.ts on lines 35..37
lib/web/src/toys/sphero-mini.ts on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

          return init();
Severity: Major
Found in lib/web/src/commands/decoder.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return error('Invalid escape char position');
    Severity: Major
    Found in lib/web/src/commands/decoder.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return error('Invalid no escape char end found');
      Severity: Major
      Found in lib/web/src/commands/decoder.ts - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (flagA === 1) {
              // tslint:disable-next-line:no-bitwise
              uAngle |= 1 << 9;
            } else {
              // tslint:disable-next-line:no-bitwise
        Severity: Minor
        Found in lib/web/src/toys/r2d2.ts and 1 other location - About 30 mins to fix
        lib/web/src/toys/r2d2.ts on lines 87..93

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                  return;
        Severity: Major
        Found in lib/web/src/commands/decoder.ts - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (flagB === 1) {
                // tslint:disable-next-line:no-bitwise
                uAngle |= 1 << 8;
              } else {
                // tslint:disable-next-line:no-bitwise
          Severity: Minor
          Found in lib/web/src/toys/r2d2.ts and 1 other location - About 30 mins to fix
          lib/web/src/toys/r2d2.ts on lines 79..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language