Sign upLogin

OpenHumans/oh-proj-management

View on GitHub
Star
project_admin/helpers.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function get_all_members has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def get_all_members(token):
    req_url = 'https://www.openhumans.org/api/direct-sharing' \
              '/project/members/?access_token={}'.format(token)
    members = requests.get(req_url).json()
    if 'results' in members.keys():
Severity: Minor
Found in project_admin/helpers.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_members has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def update_members(members, project):
    # delete members from DB if not authorized any more
    oh_ids_found = [int(member['project_member_id']) for member in members]
    for db_member in project.projectmember_set.all():
        if db_member.id not in oh_ids_found:
Severity: Minor
Found in project_admin/helpers.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status