Showing 247 of 247 total issues
Cyclomatic complexity is too high in function make_BinaryPolynomialModel_from_JSON. (7) Open
def make_BinaryPolynomialModel_from_JSON(obj):
if obj["type"] != "BinaryPolynomialModel":
raise Exception('Type must be "BinaryPolynomialModel"')
mock_polynomial = {}
if obj["index_type"] == "IndexType.INT":
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in function _BinaryPolynomialModel_from_list. (6) Open
def _BinaryPolynomialModel_from_list(keys: list, values: list, vartype):
if len(keys) == 0:
Model = make_BinaryPolynomialModel({})
return Model(keys, values, to_cxxcimod(vartype))
i = 0
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in function _make_BinaryPolynomialModel_from_hubo_from_list. (6) Open
def _make_BinaryPolynomialModel_from_hubo_from_list(keys: list, values: list):
if len(keys) == 0:
return make_BinaryPolynomialModel({}).from_hubo(keys, values)
i = 0
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Cyclomatic complexity is too high in function _make_BinaryPolynomialModel_from_hising_from_list. (6) Open
def _make_BinaryPolynomialModel_from_hising_from_list(keys: list, values: list):
if len(keys) == 0:
return make_BinaryPolynomialModel({}).from_hising(keys, values)
i = 0
- Read upRead up
- Exclude checks
Cyclomatic Complexity
Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.
Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:
Construct | Effect on CC | Reasoning |
---|---|---|
if | +1 | An if statement is a single decision. |
elif | +1 | The elif statement adds another decision. |
else | +0 | The else statement does not cause a new decision. The decision is at the if. |
for | +1 | There is a decision at the start of the loop. |
while | +1 | There is a decision at the while statement. |
except | +1 | Each except branch adds a new conditional path of execution. |
finally | +0 | The finally block is unconditionally executed. |
with | +1 | The with statement roughly corresponds to a try/except block (see PEP 343 for details). |
assert | +1 | The assert statement internally roughly equals a conditional statement. |
Comprehension | +1 | A list/set/dict comprehension of generator expression is equivalent to a for loop. |
Boolean Operator | +1 | Every boolean operator (and, or) adds a decision point. |
Consider simplifying this complex logical expression. Open
if "keys" in kwargs and "values" in kwargs and "vartype" in kwargs:
key_condition = isinstance(kwargs["keys"], list) or isinstance(
kwargs["keys"], tuple
)
val_condition = isinstance(kwargs["values"], list) or isinstance(
Similar blocks of code found in 2 locations. Consider refactoring. Open
if sample[k] == 0 and self.vartype == dimod.SPIN:
sample[k] = -1
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 42.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if sample[k] == -1 and self.vartype == dimod.BINARY:
sample[k] = 0
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 42.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function from_numpy_matrix
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def from_numpy_matrix(
Function get_state_and_energy
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def get_state_and_energy(
model, result_state, offset=0, model_variables=[]
) -> tuple[dict, float]:
"""get converted state and energy.
This function receives raw array of spins or binaries.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _make_BinaryPolynomialModel_from_hubo_from_list
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def _make_BinaryPolynomialModel_from_hubo_from_list(keys: list, values: list):
if len(keys) == 0:
return make_BinaryPolynomialModel({}).from_hubo(keys, values)
i = 0
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _BinaryPolynomialModel_from_list
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def _BinaryPolynomialModel_from_list(keys: list, values: list, vartype):
if len(keys) == 0:
Model = make_BinaryPolynomialModel({})
return Model(keys, values, to_cxxcimod(vartype))
i = 0
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _make_BinaryPolynomialModel_from_hising_from_list
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def _make_BinaryPolynomialModel_from_hising_from_list(keys: list, values: list):
if len(keys) == 0:
return make_BinaryPolynomialModel({}).from_hising(keys, values)
i = 0
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
if "keys" in kwargs and "values" in kwargs:
key_condition = isinstance(kwargs["keys"], list) or isinstance(
kwargs["keys"], tuple
)
val_condition = isinstance(kwargs["values"], list) or isinstance(
Consider simplifying this complex logical expression. Open
if "keys" in kwargs and "values" in kwargs:
key_condition = isinstance(kwargs["keys"], list) or isinstance(
kwargs["keys"], tuple
)
val_condition = isinstance(kwargs["values"], list) or isinstance(
Function bqm_from_numpy_matrix
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def bqm_from_numpy_matrix(
Function make_BinaryPolynomialModel_from_JSON
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def make_BinaryPolynomialModel_from_JSON(obj):
if obj["type"] != "BinaryPolynomialModel":
raise Exception('Type must be "BinaryPolynomialModel"')
mock_polynomial = {}
if obj["index_type"] == "IndexType.INT":
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return super().remove_interaction(args)
Avoid too many return
statements within this function. Open
return super().remove_interaction(*args, **kwargs)
Avoid too many return
statements within this function. Open
return make_BinaryPolynomialModel({}, tuple, 4)
Avoid too many return
statements within this function. Open
return cxxcimod.BinaryPolynomialModel_tuple4, "IndexType.INT_TUPLE_4"