Sign upLogin

OpenSRP/opensrp-client-anc

View on GitHub
Star
opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java

Summary

Maintainability
D
1 day
Test Coverage

Method quickCheckDangerSignsSelectionHandler has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    public void quickCheckDangerSignsSelectionHandler(JSONArray fields) throws JSONException {
        boolean none = false;
        boolean other = false;

        Fragment fragment = getVisibleFragment();
Severity: Minor
Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method init has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void init(String json) {
        try {
            setmJSONObject(new JSONObject(json));
            if (!getmJSONObject().has(ConstantsUtils.JsonFormKeyUtils.ENCOUNTER_TYPE)) {
Severity: Minor
Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkBoxWriteValue has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected void checkBoxWriteValue(String stepName, String parentKey, String childObjectKey, String childKey,
                                      String value, boolean popup) throws JSONException {
        synchronized (getmJSONObject()) {
            JSONObject jsonObject = getmJSONObject().getJSONObject(stepName);
Severity: Minor
Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method init has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void init(String json) {
        try {
            setmJSONObject(new JSONObject(json));
            if (!getmJSONObject().has(ConstantsUtils.JsonFormKeyUtils.ENCOUNTER_TYPE)) {
Severity: Minor
Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java - About 1 hr to fix

    Method writeValue has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public void writeValue(String stepName, String key, String value, String openMrsEntityParent, String openMrsEntity,
                           String openMrsEntityId, boolean popup) throws JSONException {
    Severity: Major
    Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java - About 50 mins to fix

      Method callSuperWriteValue has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected void callSuperWriteValue(String stepName, String key, String value, String openMrsEntityParent,
                                       String openMrsEntity, String openMrsEntityId, Boolean popup) throws JSONException {
      Severity: Major
      Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java - About 50 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (StringUtils.isNotBlank(formName) && formName.equals(ConstantsUtils.JsonFormUtils.ANC_QUICK_CHECK)) {
                                quickCheckDangerSignsSelectionHandler(fields);
                            }
        Severity: Major
        Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if (item != null && item.getBoolean(JsonFormConstants.VALUE)) {
                            if (item.getString(JsonFormConstants.KEY).equals(ConstantsUtils.DANGER_NONE)) {
                                none = true;
                            }
          Severity: Major
          Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java - About 45 mins to fix

            Method checkBoxWriteValue has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                protected void checkBoxWriteValue(String stepName, String parentKey, String childObjectKey, String childKey,
                                      String value, boolean popup) throws JSONException {
            Severity: Minor
            Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java - About 45 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                      for (int i = 0; i < list.size(); i++) {
                            String text = list.get(i).trim();
                            String translated_text = StringUtils.isNotBlank(text) ? NativeFormLangUtils.translateDatabaseString(text, AncLibrary.getInstance().getApplicationContext()) : "";
                            finalList.add(translated_text);
                        }
              Severity: Major
              Found in opensrp-anc/src/main/java/org/smartregister/anc/library/activity/ContactJsonFormActivity.java and 1 other location - About 1 hr to fix
              opensrp-anc/src/main/java/org/smartregister/anc/library/util/Utils.java on lines 959..963

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status