Sign upLogin

OpenSRP/opensrp-client-anc

View on GitHub
Star
opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java

Summary

Maintainability
D
2 days
Test Coverage

File AdvancedSearchFragment.java has 474 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package org.smartregister.anc.library.fragment;

import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
Severity: Minor
Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java - About 7 hrs to fix

    AdvancedSearchFragment has 40 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class AdvancedSearchFragment extends HomeRegisterFragment
        implements AdvancedSearchContract.View, RegisterFragmentContract.View {

    private View listViewLayout;
    private View advancedSearchForm;
    Severity: Minor
    Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java - About 5 hrs to fix

      Method populateFormViews has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void populateFormViews(View view) {
        search = view.findViewById(R.id.search);
        search.setEnabled(false);
        search.setTextColor(getResources().getColor(R.color.contact_complete_grey_border));
      Severity: Major
      Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                if (!TextUtils.isEmpty(ancId.getText()) || !TextUtils.isEmpty(firstName.getText()) ||
                !TextUtils.isEmpty(lastName.getText()) || !TextUtils.isEmpty(edd.getText()) ||
                !TextUtils.isEmpty(dob.getText()) || !TextUtils.isEmpty(phoneNumber.getText()) ||
                !TextUtils.isEmpty(altContactName.getText())) {
            search.setEnabled(true);
        Severity: Major
        Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java - About 1 hr to fix

          Method onViewClicked has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    protected void onViewClicked(View view) {
        if (view.getId() == R.id.search) {
            search();
        } else if (view.getId() == R.id.undo_button) {
          Severity: Minor
          Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method switchViews has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public void switchViews(boolean showList) {
        if (showList) {
            Utils.hideKeyboard(getActivity());
          Severity: Minor
          Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method onCreateLoader has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public Loader<Cursor> onCreateLoader(int id, Bundle args) {
        if (id == RecyclerViewFragment.LOADER_ID) {// Returns a new CursorLoader
            return new CursorLoader(getActivity()) {
                @Override
          Severity: Minor
          Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method updateSearchLimits has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private void updateSearchLimits() {
        if (Utils.isConnectedToNetwork(getActivity())) {
            outsideInside.setChecked(true);
            myCatchment.setChecked(false);
        } else {
          Severity: Minor
          Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  outsideInside.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
            @Override
            public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
                if (!Utils.isConnectedToNetwork(getActivity())) {
                    myCatchment.setChecked(true);
          Severity: Minor
          Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java and 1 other location - About 45 mins to fix
          opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java on lines 465..475

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  myCatchment.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
            @Override
            public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
                if (!Utils.isConnectedToNetwork(getActivity())) {
                    myCatchment.setChecked(true);
          Severity: Minor
          Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java and 1 other location - About 45 mins to fix
          opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java on lines 453..463

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  try {
            sqb.addCondition(filters);
            query = sqb.orderbyCondition(Sortqueries);
            query = sqb.Endquery(
                    sqb.addlimitandOffset(query, clientAdapter.getCurrentlimit(), clientAdapter.getCurrentoffset()));
          Severity: Minor
          Found in opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/AdvancedSearchFragment.java and 1 other location - About 35 mins to fix
          opensrp-anc/src/main/java/org/smartregister/anc/library/fragment/HomeRegisterFragment.java on lines 268..274

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status