Sign upLogin

OpenSRP/opensrp-client-anc

View on GitHub
Star
opensrp-anc/src/main/java/org/smartregister/anc/library/widget/ANCSpinnerFactory.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method populateLocationSpinner has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private void populateLocationSpinner(JSONObject jsonObject, String parentLocationId, String spinnerKey,
                                         List<String> controlsToHide) {
        List<Location> locations = Utils.getLocationsByParentId(parentLocationId);
        String selectedLocation = Utils.getCurrentLocation(spinnerKey, jsonFormView);
Severity: Minor
Found in opensrp-anc/src/main/java/org/smartregister/anc/library/widget/ANCSpinnerFactory.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method populateLocationSpinner has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void populateLocationSpinner(JSONObject jsonObject, String parentLocationId, String spinnerKey,
                                         List<String> controlsToHide) {
        List<Location> locations = Utils.getLocationsByParentId(parentLocationId);
        String selectedLocation = Utils.getCurrentLocation(spinnerKey, jsonFormView);
Severity: Minor
Found in opensrp-anc/src/main/java/org/smartregister/anc/library/widget/ANCSpinnerFactory.java - About 1 hr to fix

    Method getViewsFromJson has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public List<View> getViewsFromJson(String stepName, Context context, JsonFormFragment formFragment,
                                       JSONObject jsonObject, CommonListener listener, boolean popup) throws Exception {
    Severity: Minor
    Found in opensrp-anc/src/main/java/org/smartregister/anc/library/widget/ANCSpinnerFactory.java - About 45 mins to fix

      Method getViewsFromJson has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public List<View> getViewsFromJson(String stepName, Context context, JsonFormFragment formFragment,
                                       JSONObject jsonObject, CommonListener listener, boolean popup) throws Exception {
        this.formFragment = formFragment;
        jsonFormView = (JsonFormActivity) formFragment.getActivity();
      Severity: Minor
      Found in opensrp-anc/src/main/java/org/smartregister/anc/library/widget/ANCSpinnerFactory.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status