Sign upLogin

OperationCode/operationcode

View on GitHub
Star
old_site/app/controllers/donations_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    @donation = Donation.new(donation_params)

    unless @donation.valid?
      flash[:error] = 'Please verify all required fields are completed.'
Severity: Minor
Found in old_site/app/controllers/donations_controller.rb - About 1 hr to fix

Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    @donation = Donation.new(donation_params)

    unless @donation.valid?
      flash[:error] = 'Please verify all required fields are completed.'
Severity: Minor
Found in old_site/app/controllers/donations_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status