Sign upLogin

Opetushallitus/eperusteet-frontend-utils

View on GitHub
Star
components/editointikontrollit/editointikontrollit.ts

Summary

Maintainability
D
1 day
Test Coverage

File editointikontrollit.ts has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

interface IEditointikontrollitCallbacks {
    start?: (val?) => Promise<any>,
    preStart?: () => Promise<any>,
    preSave?: () => Promise<any>,
    save?: (kommentti?, preSavedObject?) => Promise<any>,
Severity: Minor
Found in components/editointikontrollit/editointikontrollit.ts - About 2 hrs to fix

    Function createRestangular has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        export const createRestangular = (
        scope,
        field: string,
        resolvedObj: Restangular.IElement,
        callbacks: IEditointikontrollitCallbacks = {}) => {
    Severity: Major
    Found in components/editointikontrollit/editointikontrollit.ts - About 2 hrs to fix

      Function createRestangular has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          export const createRestangular = (
        scope,
        field: string,
        resolvedObj: Restangular.IElement,
        callbacks: IEditointikontrollitCallbacks = {}) => {
      Severity: Minor
      Found in components/editointikontrollit/editointikontrollit.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function controller has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          export const controller = ($scope, $rootScope, $timeout) => {
        $scope.toggleHistoryModal = () => {
            if ($scope.$$showingHistoryModal) {
                HistoryModal.hide();
            }
      Severity: Minor
      Found in components/editointikontrollit/editointikontrollit.ts - About 1 hr to fix

        Function start has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    start: () => _$q((resolve, reject) => {
                const editoi = (osa) => {
                    _.assign(resolvedObj, osa);
                    backup = _.cloneDeep(resolvedObj);
                    scope[field] = _.clone(resolvedObj);
        Severity: Minor
        Found in components/editointikontrollit/editointikontrollit.ts - About 1 hr to fix

          Function directive has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              export const directive = ($window) => {
        return {
            templateUrl: "components/editointikontrollit/editointikontrollit.jade",
            restrict: "E",
            controller: controller,
          Severity: Minor
          Found in components/editointikontrollit/editointikontrollit.ts - About 1 hr to fix

            Function createListRestangular has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                export const createListRestangular = (
        scope,
        field: string,
        resolvedObj: Restangular.IElement) => {
        scope[field] = resolvedObj.clone();
            Severity: Minor
            Found in components/editointikontrollit/editointikontrollit.ts - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  export const init = ($state, $rootScope, $q, $log, $timeout, Restangular, Varmistusdialogi) => {
        _$state = $state;
        _$rootScope = $rootScope;
        _$timeout = $timeout;
        _$log = $log;
              Severity: Major
              Found in components/editointikontrollit/editointikontrollit.ts and 1 other location - About 1 hr to fix
              components/notifikaatiot/notifikaatiot.ts on lines 11..19

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 71.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status