Sign upLogin

Opetushallitus/eperusteet-frontend-utils

View on GitHub
Star

Showing 183 of 183 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function koulutusTyyppiTile(koulutustyyppi) {
  const themeType = themes[koulutustyyppi!] || 'lukiokoulutus';
  const imgUrl = koulutustyyppiRyhmaTiles[themeType] || tileLukio;
  return { 'background-image': `url('${imgUrl}')` };
}
Severity: Major
Found in vue/src/utils/bannerIcons.ts and 1 other location - About 1 hr to fix
vue/src/utils/bannerIcons.ts on lines 54..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function koulutustyyppiBanner(koulutustyyppi) {
  const themeType = themes[koulutustyyppi!] || 'lukiokoulutus';
  const imgUrl = koulutustyyppiRyhmaBanners[themeType] || bannerLukio;
  return { 'background-image': `url('${imgUrl}')` };
}
Severity: Major
Found in vue/src/utils/bannerIcons.ts and 1 other location - About 1 hr to fix
vue/src/utils/bannerIcons.ts on lines 60..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function link has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            link: (scope, element, attrs) => {

                scope.type = scope.type || "text";
                attrs.$observe("required", (value) => {
                    if (value === "required" || value === "true" || value === "") {
Severity: Minor
Found in components/datepicker/datepicker.ts - About 1 hr to fix

    Function kaanna has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public kaanna(value?: LokalisoituTeksti | undefined | null, emptyWhenNotFound = false, squareBrackets = true, forcedLang = null): string {
    if (!value) {
      return '';
    }
    else if (_.isObject(value)) {
    Severity: Minor
    Found in vue/src/stores/kieli.ts - About 1 hr to fix

      Function setup has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      function setup() {
                    element.find(TERMI_MATCHER).each(function () {
                        var jqEl: any = angular.element(this);
                        var viiteId: any = jqEl.attr('data-viite');
                        TermistoData.getByAvain(viiteId, $stateParams.ktId).then(function(res) {
      Severity: Minor
      Found in components/termisto/termisto.ts - About 1 hr to fix

        Function dateformatvalidator has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            export const dateformatvalidator = () => {

        return {
            restrict: "A",
            require: "ngModel",
        Severity: Minor
        Found in components/datepicker/datepicker.ts - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          export function vapaasivistystyo() {
  return [{
    name: koulutustyyppiStateName('koulutustyyppi_10'),
    route: {
      name: 'kooste',
          Severity: Major
          Found in vue/src/utils/perusteet.ts and 2 other locations - About 1 hr to fix
          vue/src/utils/perusteet.ts on lines 457..468
          vue/src/utils/perusteet.ts on lines 470..481

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          export function kotoutumiskoulutus() {
  return [{
    name: koulutustyyppiStateName('koulutustyyppi_30'),
    route: {
      name: 'kooste',
          Severity: Major
          Found in vue/src/utils/perusteet.ts and 2 other locations - About 1 hr to fix
          vue/src/utils/perusteet.ts on lines 444..455
          vue/src/utils/perusteet.ts on lines 457..468

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          export function tutkintoonvalmentava() {
  return [{
    name: koulutustyyppiStateName('koulutustyyppi_40'),
    route: {
      name: 'kooste',
          Severity: Major
          Found in vue/src/utils/perusteet.ts and 2 other locations - About 1 hr to fix
          vue/src/utils/perusteet.ts on lines 444..455
          vue/src/utils/perusteet.ts on lines 470..481

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function mockEditointiStore has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function mockEditointiStore<T>(config: Partial<IEditoitava> = {}) {
  const editointi = {
    acquire: jest.fn(async () => {
      const vanhentuu = new Date();
      vanhentuu.setMinutes(vanhentuu.getMinutes() + 10);
          Severity: Minor
          Found in vue/src/utils/jestutils.ts - About 1 hr to fix

            Function dateformatvalidator has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                export const dateformatvalidator = () => {

        return {
            restrict: "A",
            require: "ngModel",
            Severity: Minor
            Found in components/datepicker/datepicker.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                export const directive = () => {
        return {
            templateUrl: "components/toggler/toggler.jade",
            restrict: "E",
            scope: {
            Severity: Major
            Found in components/toggler/toggler.ts and 1 other location - About 1 hr to fix
            components/ohje/ohje.ts on lines 32..44

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                export const directive = () => {
        return {
            templateUrl: "components/ohje/ohje.jade",
            restrict: "AE",
            scope: {
            Severity: Major
            Found in components/ohje/ohje.ts and 1 other location - About 1 hr to fix
            components/toggler/toggler.ts on lines 13..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function link has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    link: (scope, el, attrs) => {
            const kaannaValue = (value) => _.isObject(value)
                ? KaannaService.kaannaSisalto(value)
                : KaannaService.kaanna(value);
            const original = getAttr(attrs["kaanna"], scope) || el.text();
            Severity: Minor
            Found in components/lokalisointi/kaanna.ts - About 1 hr to fix

              Function getLaajaAlaisetKoodit has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export function getLaajaAlaisetKoodit() {
  return [{
    koodi: 'lops2019laajaalainenosaaminen_1',
    nimi: {
      fi: 'Globaali- ja kulttuuriosaaminen',
              Severity: Minor
              Found in vue/src/utils/perusteet.ts - About 1 hr to fix

                Function start has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            start: () => _$q((resolve, reject) => {
                const editoi = (osa) => {
                    _.assign(resolvedObj, osa);
                    backup = _.cloneDeep(resolvedObj);
                    scope[field] = _.clone(resolvedObj);
                Severity: Minor
                Found in components/editointikontrollit/editointikontrollit.ts - About 1 hr to fix

                  Function save has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    public async save() {
    this.state.disabled = true;
    this.state.isSaving = true;

    if (!this.isEditing.value) {
                  Severity: Minor
                  Found in vue/src/components/EpEditointi/EditointiStore.ts - About 1 hr to fix

                    Function directive has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        export const directive = ($window) => {
        return {
            templateUrl: "components/editointikontrollit/editointikontrollit.jade",
            restrict: "E",
            controller: controller,
                    Severity: Minor
                    Found in components/editointikontrollit/editointikontrollit.ts - About 1 hr to fix

                      Function createListRestangular has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          export const createListRestangular = (
        scope,
        field: string,
        resolvedObj: Restangular.IElement) => {
        scope[field] = resolvedObj.clone();
                      Severity: Minor
                      Found in components/editointikontrollit/editointikontrollit.ts - About 1 hr to fix

                        Function doDiff has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                    const doDiff = (oldVersion?, newVersion?) => {
                oldVersion = oldVersion || $scope.currentHistoryItem;
                newVersion = newVersion || $scope.data;

                if (!oldVersion || !oldVersion[$scope.selectedLang]) {
                        Severity: Minor
                        Found in components/history/history.ts - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language