Sign upLogin

Opetushallitus/eperusteet-opintopolku

View on GitHub
Star
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts

Summary

Maintainability
C
1 day
Test Coverage

Function epEsitysTiedotController has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    export const epEsitysTiedotController = (
        $scope,
        $q,
        $state,
        YleinenData,
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts - About 1 hr to fix

    Function epEsitysTutkinnonOsaController has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        export const epEsitysTutkinnonOsaController = (
        $scope,
        $state,
        $stateParams,
        PerusteenOsat,
    Severity: Minor
    Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts - About 1 hr to fix

      Function epEsitysSisaltoController has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          export const epEsitysSisaltoController = (
        $scope,
        $state,
        $stateParams,
        PerusteenOsat,
      Severity: Minor
      Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts - About 1 hr to fix

        Function epEsitysTutkinnonOsatController has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            export const epEsitysTutkinnonOsatController = (
        $scope,
        $state,
        $stateParams,
        Algoritmit,
        Severity: Minor
        Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts - About 1 hr to fix

          Function epEsitysTiedotController has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              export const epEsitysTiedotController = (
        $scope,
        $q,
        $state,
        YleinenData,
          Severity: Minor
          Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $scope.voimassaOleva = !!(
            !$scope.peruste.voimassaoloLoppuu ||
            ($scope.peruste.voimassaoloAlkaa &&
                currentTime > $scope.peruste.voimassaoloAlkaa &&
                currentTime < $scope.peruste.voimassaoloLoppuu)
          Severity: Major
          Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts and 1 other location - About 1 hr to fix
          eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/lukio.ts on lines 368..373

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ($scope.peruste.maarayskirje && _.isEmpty($scope.peruste.maarayskirje.liitteet)) {
            $scope.peruste.maarayskirje.$$naytaUrl = true;
            if (_.isEmpty($scope.peruste.maarayskirje.url)) {
                $scope.peruste.maarayskirje.$$hide = true;
            }
          Severity: Major
          Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts and 1 other location - About 1 hr to fix
          eperusteet-opintopolku-app/yo/app/data/dokumentit.ts on lines 27..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              $scope.osaamisalakuvaukset = _(osaamisalakuvaukset.plain())
                        .values()
                        .map(_.values)
                        .flatten()
                        .flatten()
          Severity: Major
          Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts and 1 other location - About 1 hr to fix
          eperusteet-opintopolku-app/yo/app/states/selaus/ammatillinenkoulutus/peruste/state.ts on lines 169..174

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status