Sign upLogin

Opetushallitus/eperusteet-opintopolku

View on GitHub
Star
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts

Summary

Maintainability
D
1 day
Test Coverage

Function epYksinkertainenPerusteController has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    export const epYksinkertainenPerusteController = (
        $q,
        $scope,
        $timeout,
        sisalto,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts - About 4 hrs to fix

    Function epYksinkertainenPerusteController has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        export const epYksinkertainenPerusteController = (
        $q,
        $scope,
        $timeout,
        sisalto,
    Severity: Minor
    Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            $scope.naviClasses = function(item) {
            let classes = ["depth" + item.depth];
            if (item.$selected) {
                classes.push("tekstisisalto-active");
            }
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts and 2 other locations - About 2 hrs to fix
    eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/perusopetus.ts on lines 66..75
    eperusteet-opintopolku-app/yo/app/scripts/views/ops/yksinkertainen.ts on lines 76..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (
                $state.current.name === currentRootState &&
                (!$state.includes("**.tiedot") || !$stateParams.perusteId)
            ) {
                $state.go(".tiedot", { perusteId: $scope.peruste.id }, { location: "replace" });
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts and 1 other location - About 2 hrs to fix
    eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/aipe.ts on lines 107..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            function clickHandler(event) {
            const ohjeEl = angular.element(event.target).closest(".popover, .popover-element");
            if (ohjeEl.length === 0) {
                $rootScope.$broadcast("ohje:closeAll");
            }
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts and 2 other locations - About 1 hr to fix
    eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/lukio.ts on lines 88..93
    eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/perusopetus.ts on lines 77..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

            $scope.hasContent = function(obj) {
            return _.isObject(obj) && obj.teksti && obj.teksti[Kieli.getSisaltokieli()];
        };
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts and 4 other locations - About 1 hr to fix
    eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/lukio.ts on lines 118..120
    eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/perusopetus.ts on lines 42..44
    eperusteet-opintopolku-app/yo/app/scripts/views/ops/lukioopetus.ts on lines 43..45
    eperusteet-opintopolku-app/yo/app/scripts/views/ops/perusopetus.ts on lines 38..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    } else if (item.tyyppi === "taiteenala") {
                    item.href = $state.href(currentRootState + ".taiteenala", {
                        perusteId: $scope.peruste.id,
                        tekstikappaleId: osa.id
                    });
    Severity: Minor
    Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts and 1 other location - About 45 mins to fix
    eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts on lines 136..141

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    } else {
                    item.href = $state.href(currentRootState + ".tekstikappale", {
                        perusteId: $scope.peruste.id,
                        tekstikappaleId: osa.id
                    });
    Severity: Minor
    Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts and 1 other location - About 45 mins to fix
    eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts on lines 131..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status