Sign upLogin

Opetushallitus/eperusteet-opintopolku

View on GitHub
Star
eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts

Summary

Maintainability
D
2 days
Test Coverage

Function HakuController has 202 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    export const HakuController = (
        $scope,
        $rootScope,
        $state,
        SpinnerService,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 1 day to fix

    Function HakuController has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        export const HakuController = (
        $scope,
        $rootScope,
        $state,
        SpinnerService,
    Severity: Minor
    Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File haku.ts has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (c) 2013 The Finnish Board of Education - Opetushallitus
 *
 * This program is free software: Licensed under the EUPL, Version 1.1 or - as
 * soon as they will be approved by the European Commission - subsequent versions
    Severity: Minor
    Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 2 hrs to fix

      Function Haku has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      angular.module("app").service("Haku", function Haku(Kieli) {
    const uikieli = Kieli.getUiKieli();

    const COMMON = {
        kieli: uikieli,
      Severity: Minor
      Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 1 hr to fix

        Function selvitaTila has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                $scope.selvitaTila = peruste => {
            let currentTime = new Date().getTime();
            let voimassaoloAlkaa = peruste.voimassaoloAlkaa;
            let voimassaoloLoppuu = peruste.voimassaoloLoppuu;
            let siirtymaPaattyy = peruste.siirtymaPaattyy;
        Severity: Minor
        Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                              return;
          Severity: Major
          Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return;
            Severity: Major
            Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 30 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          if ($scope.hakuparametrit.koulutusala) {
                $scope.opintoalat = (<any>_.findWhere($scope.koulutusalat, {
                    koodi: $scope.hakuparametrit.koulutusala
                })).opintoalat;
                _.each($scope.opintoalat, ala => {
              Severity: Major
              Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts and 2 other locations - About 4 hrs to fix
              eperusteet-opintopolku-app/yo/app/states/selaus/ammatillinenkoulutus/state.ts on lines 280..290
              eperusteet-opintopolku-app/yo/app/states/selaus/ammatillinenkoulutus/state.ts on lines 548..558

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status