Sign upLogin

Opetushallitus/eperusteet-opintopolku

View on GitHub
Star
eperusteet-opintopolku-app/yo/app/states/ops/state.ts

Summary

Maintainability
D
1 day
Test Coverage

File state.ts has 449 lines of code (exceeds 250 allowed). Consider refactoring.
Open

angular.module("app").config($stateProvider => {
    const YksinkertaistenResolve = {
        viiteId: function(serviceConfig, $stateParams) {
            return $stateParams.tekstikappaleId;
        },
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts - About 6 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                resolve: {
                viiteId: function(serviceConfig, $stateParams) {
                    return $stateParams.tekstikappaleId;
                },
                tekstikappaleWithChildren: function(opsResource, viiteId, opsId) {
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts and 1 other location - About 2 hrs to fix
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 2..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        const YksinkertaistenResolve = {
        viiteId: function(serviceConfig, $stateParams) {
            return $stateParams.tekstikappaleId;
        },
            tekstikappaleWithChildren: function(opsResource, viiteId, opsId) {
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts and 1 other location - About 2 hrs to fix
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 166..180

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        $stateProvider
        .state("root.ops", {
            url: "/ops/:opsId",
            template: "<div ui-view></div>",
            controller: "OpsController",
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts and 3 other locations - About 1 hr to fix
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 17..370
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 17..410
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 17..437

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    otsikot: function(opsResource, opsId) {
                    return opsResource
                        .getOtsikot({
                            opsId: opsId
                        })
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts and 2 other locations - About 45 mins to fix
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 146..150
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 219..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    baseLaajaalaiset: function(opsId, opsResource) {
                    return opsResource
                        .getLaajaalaisetosaamiset({
                            opsId: opsId
                        })
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts and 2 other locations - About 45 mins to fix
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 146..150
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 151..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    perusOps: function(opsResource, opsId) {
                    return opsResource.get({ opsId: opsId }).$promise.then(function(res) {
                        return res;
                    });
                },
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts and 2 other locations - About 45 mins to fix
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 151..159
    eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 219..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    vuosiluokkaSisalto: (opsResource, vlkId, opsId, oppiaineId, vuosiluokkaId) =>
                    opsResource.getOppiaineVlkByVuosiluokka({ opsId, oppiaineId, vlkId, vuosiId: vuosiluokkaId })
                        .$promise
    Severity: Minor
    Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts and 1 other location - About 35 mins to fix
    eperusteet-opintopolku-app/yo/app/states/aipe/kurssi/state.ts on lines 31..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status