Sign upLogin

Opetushallitus/eperusteet-opintopolku

View on GitHub
Star

Showing 606 of 606 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            'tutkintonimike': {
              'nimi': {
                'sv': 'ICT-montör',
                'fi': 'ICT-asentaja',
                'en': 'ICT Technician',
Severity: Minor
Found in src/components/EpAmmatillinen/tests/data.ts and 2 other locations - About 35 mins to fix
src/components/EpAmmatillinen/tests/data.ts on lines 74..84
src/components/EpAmmatillinen/tests/data.ts on lines 339..349

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (tyyppi === "yhteinen") {
                    $timeout(() => {
                        return $state.go("root.ops.perusopetus.oppiaineet", {
                            opsId: $scope.ops.id,
                            oppiaineId: oppiaineId
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/perusopetus.ts and 1 other location - About 35 mins to fix
eperusteet-opintopolku-app/yo/app/scripts/views/ops/perusopetus.ts on lines 201..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function epEsitysTiedotController has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    export const epEsitysTiedotController = (
        $scope,
        $q,
        $state,
        YleinenData,
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/sisallot.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function YleinenData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

angular.module("app").service("YleinenData", function YleinenData($rootScope, Arviointiasteikot, Notifikaatiot) {
    this.rakenneRyhmaRoolit = ["määritelty", "määrittelemätön", "vieras"];

    this.osaamisalaRooli = "osaamisala";
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/scripts/common/services/yleinendata.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setUiKieli has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    export const setUiKieli = async (kielikoodi, doStateChange?) => {
        if (
            isValidKielikoodi(kielikoodi) &&
            (kielikoodi !== uikieli || (stateInited && _$stateParams.lang !== kielikoodi))
        ) {
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/components/lokalisointi/kieli.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function epAipeController has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    export const epAipeController = (
        $scope,
        perusteId,
        $state,
        $stateParams,
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/aipe.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function OpsYksinkertainenController has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    export const OpsYksinkertainenController = (
        $q,
        $scope,
        $document,
        $state,
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/yksinkertainen.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getAliviiteIds has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  private getAliviiteIds() {
    if (!_.isEmpty(this.tekstiKappaleViite)) {
      const viitteet: any[] = [];
      const stack = [this.tekstiKappaleViite!];
Severity: Minor
Found in src/stores/OpetussuunnitelmaTekstikappaleStore.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                vuosiluokkaSisalto: (opsResource, vlkId, opsId, oppiaineId, vuosiluokkaId) =>
                    opsResource.getOppiaineVlkByVuosiluokka({ opsId, oppiaineId, vlkId, vuosiId: vuosiluokkaId })
                        .$promise
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/states/ops/state.ts and 1 other location - About 35 mins to fix
eperusteet-opintopolku-app/yo/app/states/aipe/kurssi/state.ts on lines 31..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            kurssi: (oppiaineId, perusteId, vaiheId, kurssiId, AipeKurssit) =>
                AipeKurssit.get({
                    perusteId: perusteId,
                    vaiheId: vaiheId,
                    oppiaineId: oppiaineId,
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/states/aipe/kurssi/state.ts and 1 other location - About 35 mins to fix
eperusteet-opintopolku-app/yo/app/states/ops/state.ts on lines 278..280

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

                                return;
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/states/selaus/ammatillinenkoulutus/state.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                            return;
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/states/selaus/ammatillinenkoulutus/state.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return;
      Severity: Major
      Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return true;
        Severity: Major
        Found in eperusteet-opintopolku-app/yo/app/scripts/views/ylanavigaatio.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                                          return;
          Severity: Major
          Found in eperusteet-opintopolku-app/yo/app/states/selaus/ammatillinenkoulutus/state.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return true;
            Severity: Major
            Found in eperusteet-opintopolku-app/yo/app/scripts/views/ylanavigaatio.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return;
              Severity: Major
              Found in eperusteet-opintopolku-app/yo/app/scripts/views/haku/haku.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return [{
      tyyppi: 'voimassa',
      teksti: voimassaoloTietoTekstit['voimassa'],
      paiva: voimassaoloAlkaa,
    }];
                Severity: Major
                Found in src/utils/voimassaolo.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return true;
                  Severity: Major
                  Found in eperusteet-opintopolku-app/yo/app/scripts/views/ylanavigaatio.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                            return;
                    Severity: Major
                    Found in eperusteet-opintopolku-app/yo/app/states/selaus/ammatillinenkoulutus/state.ts - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language