Sign upLogin

Opetushallitus/eperusteet-opintopolku

View on GitHub
Star

Showing 607 of 607 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

              {
                'kuvaus': null,
                'vieras': null,
                'tunniste': '58ddb00b-2ac0-4f21-93ae-f998e3d54580',
                'pakollinen': false,
Severity: Major
Found in src/components/EpAmmatillinen/tests/data.ts and 2 other locations - About 6 hrs to fix
src/components/EpAmmatillinen/tests/data.ts on lines 239..277
src/components/EpAmmatillinen/tests/data.ts on lines 277..315

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 170.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            'osat': [{
              'kuvaus': null,
              'vieras': null,
              'tunniste': '305e1e80-dd2c-41e1-92ad-1293a6329efe',
              'pakollinen': false,
Severity: Major
Found in src/components/EpAmmatillinen/tests/data.ts and 2 other locations - About 6 hrs to fix
src/components/EpAmmatillinen/tests/data.ts on lines 166..204
src/components/EpAmmatillinen/tests/data.ts on lines 277..315

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 170.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            {
                oma: true,
                oppiaine: {
                    id: 59129,
                    tunniste: "0aab037c-a9e6-4816-8350-2a76e428b8ff",
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 1 other location - About 6 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 537..577

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 167.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            {
                oma: true,
                oppiaine: {
                    id: 59121,
                    tunniste: "a7cf2f77-3cce-4aa4-89ab-e64a84e25105",
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 1 other location - About 6 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 699..739

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 167.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function epLukioOppiaineController has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    export const epLukioOppiaineController = (
        $scope,
        $location,
        epLukioStateService,
        Utils,
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/lukio.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            {
                oma: true,
                oppiaine: {
                    id: 59126,
                    tunniste: "752ca235-8e9a-4a9c-ad6c-8bb80e1e0be9",
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 1 other location - About 6 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 1210..1250

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 164.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            {
                oma: true,
                oppiaine: {
                    id: 59128,
                    tunniste: "dc7c6c2d-5b41-42e5-876b-dc8242e3fd66",
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 1 other location - About 6 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 978..1018

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 164.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File tree.ts has 434 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2013 The Finnish Board of Education - Opetushallitus
 *
 * This program is free software: Licensed under the EUPL, Version 1.1 or - as
 * soon as they will be approved by the European Commission - subsequent versions
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/directives/tree.ts - About 6 hrs to fix

    File perusopetus.ts has 433 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (c) 2013 The Finnish Board of Education - Opetushallitus
 *
 * This program is free software: Licensed under the EUPL, Version 1.1 or - as
 * soon as they will be approved by the European Commission - subsequent versions
    Severity: Minor
    Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/perusopetus.ts - About 6 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                          (col, item: any, index, all) => {
                        if (item._vuosiluokkakokonaisuus === vlk) {
                            _.isEmpty(item.vuosiluokat) ? col.unshift("all") : col.unshift(item.vuosiluokat);
                        }
                        if (all.length - 1 === index) {
      Severity: Major
      Found in eperusteet-opintopolku-app/yo/app/scripts/common/services/opsmenubuilders.ts and 1 other location - About 6 hrs to fix
      eperusteet-opintopolku-app/yo/app/scripts/views/ops/opsutils.ts on lines 119..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 156.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                          function(col, item: any, index, all) {
                        if (item._vuosiluokkakokonaisuus === vlk) {
                            _.isEmpty(item.vuosiluokat) ? col.unshift("all") : col.unshift(item.vuosiluokat);
                        }
                        if (all.length - 1 === index) {
      Severity: Major
      Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/opsutils.ts and 1 other location - About 6 hrs to fix
      eperusteet-opintopolku-app/yo/app/scripts/common/services/opsmenubuilders.ts on lines 128..139

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 156.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              const getCurrentVlk = vlk => {
            var vuodet = vlk.nimi.fi.replace(/\D/g, "").split("") || vlk.nimi.sv.replace(/\D/g, "").split("");
            vuodet = _.map(vuodet, function(v: any) {
                return parseInt(v);
            });
      Severity: Major
      Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/perusopetus.ts and 1 other location - About 5 hrs to fix
      eperusteet-opintopolku-app/yo/app/scripts/views/ops/perusopetus.ts on lines 386..392

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 154.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              const getCurrentVlk = vlk => {
            var vuodet = vlk.nimi.fi.replace(/\D/g, "").split("") || vlk.nimi.sv.replace(/\D/g, "").split("");
            vuodet = _.map(vuodet, function(v: any) {
                return parseInt(v);
            });
      Severity: Major
      Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/perusopetus.ts and 1 other location - About 5 hrs to fix
      eperusteet-opintopolku-app/yo/app/scripts/views/ops/perusopetus.ts on lines 475..481

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 154.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function epLukioController has 148 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          export const epLukioController = (
        $q,
        $scope,
        $rootScope,
        $state,
      Severity: Major
      Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/lukio.ts - About 5 hrs to fix

        Function controller has 147 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        controller: (
                    $q,
                    $rootScope,
                    $scope,
                    $state,
        Severity: Major
        Found in eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts - About 5 hrs to fix

          Function YleinenData has 144 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          angular.module("app").service("YleinenData", function YleinenData($rootScope, Arviointiasteikot, Notifikaatiot) {
    this.rakenneRyhmaRoolit = ["määritelty", "määrittelemätön", "vieras"];

    this.osaamisalaRooli = "osaamisala";
          Severity: Major
          Found in eperusteet-opintopolku-app/yo/app/scripts/common/services/yleinendata.ts - About 5 hrs to fix

            File perusopetus.ts has 403 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /*
 * Copyright (c) 2013 The Finnish Board of Education - Opetushallitus
 *
 * This program is free software: Licensed under the EUPL, Version 1.1 or - as
 * soon as they will be approved by the European Commission - subsequent versions
            Severity: Minor
            Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/perusopetus.ts - About 5 hrs to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (osa.tosa.tyyppi === "perusteesta") {
                        if (osa.peruste) {
                            // Tuotu toisesta perusteesta
                            perusteId = osa.peruste.id;
                        } else {
              Severity: Major
              Found in eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts and 1 other location - About 5 hrs to fix
              eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts on lines 38..51

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 144.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (osa.tosa.tyyppi === "perusteesta") {
                        if (osa.peruste) {
                            // Tuotu toisesta perusteesta
                            perusteId = osa.peruste.id;
                        } else {
              Severity: Major
              Found in eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts and 1 other location - About 5 hrs to fix
              eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts on lines 60..73

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 144.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              angular
    .module("eperusteet.esitys")
    .service("epTekstikappaleChildResolver", function(Algoritmit, $q, PerusteenOsat, LukioTekstikappale) {
        var lapset = null;
        var resource;
              Severity: Major
              Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/tekstikappaleutils.ts and 1 other location - About 5 hrs to fix
              eperusteet-opintopolku-app/yo/app/scripts/views/esitys/esitys.ts on lines 149..177

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 140.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language