Sign upLogin

Opetushallitus/eperusteet-opintopolku

View on GitHub
Star

Showing 606 of 606 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            {
                oma: true,
                oppiaine: {
                    id: 59015,
                    tunniste: "ae9cd11f-219a-4a58-ace8-0aeae63ae94d",
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 3 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 920..948
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 949..977
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 1292..1320

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            {
                oma: true,
                oppiaine: {
                    id: 59019,
                    tunniste: "e2f19be6-004b-4aaf-9660-3316c6cc6a3d",
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 3 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 851..879
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 920..948
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 949..977

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            {
                oma: true,
                oppiaine: {
                    id: 59012,
                    tunniste: "823e4670-1810-40c3-89d0-e7f0b90b1171",
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 3 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 851..879
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 920..948
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 1292..1320

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            if (selected && section) {
                var menuItems = items || section.items;
                var parent = selected.$parent;
                while (_.isNumber(parent)) {
                    menuItems[parent].$header = true;
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/common/services/lukioopsstateservice.ts and 3 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/lukiostateservice.ts on lines 140..150
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts on lines 166..176
eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts on lines 327..337

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            {
                id: 15222,
                _vuosiluokkakokonaisuus: "20eb717e-7c3a-4e40-8e78-3a9cedcaaeef",
                tehtava: {
                    id: 15240,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 2 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 1367..1394
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 1423..1450

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                        item.sisaltoalueet = item.sisaltoalueet.sort((a, b) => {
                            if (
                                sortHelper.indexOf(a.sisaltoalueet.nimi.fi) >
                                sortHelper.indexOf(b.sisaltoalueet.nimi.fi)
                            ) {
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/common/services/opsutils.ts and 1 other location - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/views/ops/opsutils.ts on lines 234..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            {
                id: 15224,
                _vuosiluokkakokonaisuus: "5dcac804-6631-405e-8aa0-22ad532c2766",
                tehtava: {
                    id: 15248,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 2 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 1367..1394
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 1395..1422

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        function processSection(navi, index, cb) {
            section = navi.sections[index];
            if (index === 1) {
                state.vlk = true;
            }
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts and 2 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/lukiostateservice.ts on lines 24..34
eperusteet-opintopolku-app/yo/app/scripts/common/services/lukioopsstateservice.ts on lines 23..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        function processSection(navi, index, cb) {
            section = navi.sections[index];
            if (index === 1) {
                state.oppiaine = true;
            }
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/lukiostateservice.ts and 2 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts on lines 30..40
eperusteet-opintopolku-app/yo/app/scripts/common/services/lukioopsstateservice.ts on lines 23..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            if (selected && section) {
                var menuItems = items || section.items;
                var parent = selected.$parent;
                while (_.isNumber(parent)) {
                    menuItems[parent].$header = true;
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts and 3 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/lukiostateservice.ts on lines 140..150
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts on lines 166..176
eperusteet-opintopolku-app/yo/app/scripts/common/services/lukioopsstateservice.ts on lines 144..154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            if (selected && section) {
                var menuItems = items || section.items;
                var parent = selected.$parent;
                while (_.isNumber(parent)) {
                    menuItems[parent].$header = true;
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts and 3 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/lukiostateservice.ts on lines 140..150
eperusteet-opintopolku-app/yo/app/scripts/common/services/lukioopsstateservice.ts on lines 144..154
eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts on lines 327..337

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                        item.sisaltoalueet = item.sisaltoalueet.sort(function(a, b) {
                            if (
                                sortHelper.indexOf(a.sisaltoalueet.nimi.fi) >
                                sortHelper.indexOf(b.sisaltoalueet.nimi.fi)
                            ) {
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/opsutils.ts and 1 other location - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/common/services/opsutils.ts on lines 75..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        function processSection(navi, index, cb) {
            section = navi.sections[index];
            if (index === 1) {
                state.oppiaine = true;
            }
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/common/services/lukioopsstateservice.ts and 2 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/lukiostateservice.ts on lines 24..34
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts on lines 30..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                kurssi: {
                    index: 1,
                    callback: function(item) {
                        if (item.$vaihe != null) {
                            item.$selected = "" + $stateParams.vaiheId === "" + item.$vaihe.id;
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts and 1 other location - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts on lines 213..227

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                vaihe: {
                    index: 1,
                    callback: function(item) {
                        if (item.$vaihe != null) {
                            item.$selected = "" + $stateParams.vaiheId === "" + item.$vaihe.id;
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts and 1 other location - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts on lines 228..242

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            {
                id: 15223,
                _vuosiluokkakokonaisuus: "5b8ee13b-4d18-416b-8626-cdcff1361f55",
                tehtava: {
                    id: 15244,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts and 2 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 1395..1422
eperusteet-opintopolku-app/yo/app/scripts/peruste/resources/fakedata.ts on lines 1423..1450

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            if (selected && section) {
                var menuItems = items || section.items;
                var parent = selected.$parent;
                while (_.isNumber(parent)) {
                    menuItems[parent].$header = true;
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/lukiostateservice.ts and 3 other locations - About 4 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts on lines 166..176
eperusteet-opintopolku-app/yo/app/scripts/common/services/lukioopsstateservice.ts on lines 144..154
eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts on lines 327..337

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File state.ts has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (c) 2013 The Finnish Board of Education - Opetushallitus
 *
 * This program is free software: Licensed under the EUPL, Version 1.1 or - as
 * soon as they will be approved by the European Commission - subsequent versions
Severity: Minor
Found in eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts - About 4 hrs to fix

    Function epYksinkertainenPerusteController has 101 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        export const epYksinkertainenPerusteController = (
        $q,
        $scope,
        $timeout,
        sisalto,
    Severity: Major
    Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/yksinkertainen.ts - About 4 hrs to fix

      OpetussuunnitelmaDataStore has 32 functions (exceeds 20 allowed). Consider refactoring.
      Open

      @Store
export class OpetussuunnitelmaDataStore implements IOpetussuunnitelmaStore {
  @State() public opetussuunnitelma: OpetussuunnitelmaExportDto | null = null;
  @State() public opetussuunnitelmaPerusteenId: number | null = null;
  @State() public opetussuunnitelmaId: number;
      Severity: Minor
      Found in src/stores/OpetussuunnitelmaDataStore.ts - About 4 hrs to fix
        Severity
        Category
        Status
        Source
        Language