Sign upLogin

P4BGroup/ldap-jwt-authentication

View on GitHub
Star

Showing 3 of 7 total issues

Avoid using static access to class '\Firebase\JWT\JWT' in method 'encode'.
Open

        return JWT::encode($claims->toArray(), $this->encodeKey, $this->algorithm);
Severity: Minor
Found in src/JWTTokensService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Firebase\JWT\JWT' in method 'decode'.
Open

            $rawClaims = JWT::decode($token, new Key($this->decodeKey, $this->algorithm));
Severity: Minor
Found in src/JWTTokensService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Line exceeds 120 characters; contains 144 characters
Open

    public function authenticateUser(string $username, string $password, string $baseDn = null, $ldapSearchScope = Ldap::SEARCH_SCOPE_ONE): User
Severity: Minor
Found in src/AuthenticationService.php by phpcodesniffer
Severity
Category
Status
Source
Language