Sign upLogin

PDF-Archiver/PDF-Archiver

View on GitHub
Star
ArchiveCore/Tests/ArchiveBackendTests/helper/XCTestCase.swift

Summary

Maintainability
A
1 hr
Test Coverage

Function assertEqualPDFDocuments has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    func assertEqualPDFDocuments(left: PDFDocument, right: PDFDocument) {
        guard left.pageCount == right.pageCount else {
            XCTFail("Documents have different page count")
            return
        }
Severity: Minor
Found in ArchiveCore/Tests/ArchiveBackendTests/helper/XCTestCase.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return UIImage(cgImage: cgImage).png
Severity: Major
Found in ArchiveCore/Tests/ArchiveBackendTests/helper/XCTestCase.swift - About 30 mins to fix

    Line should be 120 characters or less: currently 140 characters
    Open

                                return (first.r != second.r || first.g != second.g || first.b != second.b || first.a != second.a) ? diff : same;
    Severity: Minor
    Found in ArchiveCore/Tests/ArchiveBackendTests/helper/XCTestCase.swift by swiftlint

    Line should be 120 characters or less: currently 128 characters
    Open

                        add(XCTAttachment(uniformTypeIdentifier: "image/png", name: "left image", payload: dataLeft, userInfo: nil))
    Severity: Minor
    Found in ArchiveCore/Tests/ArchiveBackendTests/helper/XCTestCase.swift by swiftlint

    Line should be 120 characters or less: currently 137 characters
    Open

                            add(XCTAttachment(uniformTypeIdentifier: "image/png", name: "diff image", payload: diffImageData, userInfo: nil))
    Severity: Minor
    Found in ArchiveCore/Tests/ArchiveBackendTests/helper/XCTestCase.swift by swiftlint

    Line should be 120 characters or less: currently 130 characters
    Open

                        add(XCTAttachment(uniformTypeIdentifier: "image/png", name: "right image", payload: dataRight, userInfo: nil))
    Severity: Minor
    Found in ArchiveCore/Tests/ArchiveBackendTests/helper/XCTestCase.swift by swiftlint

    There are no issues that match your filters.

    Category