PDF-Archiver/PDF-Archiver

View on GitHub

Showing 484 of 484 total issues

Variable name should be between 3 and 40 characters long: 'at'
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

    func save(data: Data, at: URL) throws {

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .unableToLoadAppleIncRootCertificate:

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .yearMonthDay(let date):

Line should be 120 characters or less: currently 163 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

    static let longTextPDFUrl = URL(fileURLWithPath: Bundle.module.path(forResource: "AVB_PlusGarantie_EP_Zurich_01102019", ofType: "pdf", inDirectory: "assets")!)

Line should be 120 characters or less: currently 134 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

//        guard let sortedDocuments2 = try? sort(documents, by: [filenameSortDescriptor2]) else { XCTFail("Sorting failed!"); return }

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

                case .iapView:

Line should be 120 characters or less: currently 162 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

        try FileManager.default.copyItem(at: Bundle.billJPGGUrl, to: Self.tempFolder.appendingPathComponent(uuid.uuidString + "-1").appendingPathExtension("jpg"))

Line should be 120 characters or less: currently 124 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

        let creatorAttribute = try XCTUnwrap(document.documentAttributes?[PDFDocumentAttribute.creatorAttribute] as? String)

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .receiptDataNotFound:

Variable name should be between 3 and 40 characters long: 'id'
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

    public var id: String { rawValue }

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .tag:

Line should be 120 characters or less: currently 125 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            return NSLocalizedString("document_failure_reason__rename_failed_file_already_exists", comment: "Rename failed.")

Line should be 120 characters or less: currently 129 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            UserNotification.schedule(title: "Background Task Completed 🎉", message: "Status: \(success ? "success" : "failed")")

Line should be 120 characters or less: currently 214 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

//        let document1 = Document(path: URL(fileURLWithPath: "~/Downloads/2018-05-12--aaa-example-description__tag1_tag2.pdf"), taggingStatus: .tagged, downloadStatus: defaultDownloadStatus, byteSize: defaultSize)

Line should be 120 characters or less: currently 124 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

        let creatorAttribute = try XCTUnwrap(document.documentAttributes?[PDFDocumentAttribute.creatorAttribute] as? String)

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .dataIsInvalid:

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .appleIncRootCertificateNotFound:

Line should be 120 characters or less: currently 133 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

    static let billPNGUrl = URL(fileURLWithPath: Bundle.module.path(forResource: "document1", ofType: "png", inDirectory: "assets")!)

Line should be 120 characters or less: currently 128 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            return NSLocalizedString("document_error_description__rename_failed_file_already_exists", comment: "Rename failed.")

Line should be 120 characters or less: currently 152 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            return NSLocalizedString("document_recovery_suggestion__tags_missing", comment: "No tags could be found, e.g. while renaming the document.")

Line should be 120 characters or less: currently 172 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            Document(path: URL(fileURLWithPath: "~/Downloads/2018-05-12--example-description__tag=1_TaG3.pdf"), taggingStatus: .tagged, downloadStatus: .local, byteSize: 0)

Line should be 120 characters or less: currently 208 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

        let document1 = Document(path: URL(fileURLWithPath: "~/Downloads/2018-05-12--example-description__tag1_tag2.pdf"), taggingStatus: .tagged, downloadStatus: defaultDownloadStatus, byteSize: defaultSize)

Line should be 120 characters or less: currently 208 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

        let document1 = Document(path: URL(fileURLWithPath: "~/Downloads/2018-05-12--example-description__tag1_tag2.pdf"), taggingStatus: .tagged, downloadStatus: defaultDownloadStatus, byteSize: defaultSize)

Line should be 120 characters or less: currently 129 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

        let document = Document(path: path, taggingStatus: .tagged, downloadStatus: defaultDownloadStatus, byteSize: defaultSize)

Line should be 120 characters or less: currently 124 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

        let creatorAttribute = try XCTUnwrap(document.documentAttributes?[PDFDocumentAttribute.creatorAttribute] as? String)

Line should be 120 characters or less: currently 124 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

                                             localizedSubtitle: NSLocalizedString("Start scanning a document", comment: ""),
Severity: Minor
Found in Shared/PDFArchiverApp.swift by swiftlint

Line should be 120 characters or less: currently 126 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

         let sceneConfiguration = UISceneConfiguration(name: "Custom Configuration", sessionRole: connectingSceneSession.role)
Severity: Minor
Found in Shared/PDFArchiverApp.swift by swiftlint

Variable name should be between 3 and 40 characters long: 'at'
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

    func save(data: Data, at: URL) throws

Line should be 120 characters or less: currently 150 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            // if a folder was deleted during enumeration, there occurs a "no such file" error - we assume that there will be another change triggered

Type name should only contain alphanumeric characters: 'MarkdownView_Previews'
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

struct MarkdownView_Previews: PreviewProvider {

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .tag(let tagName):

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .yearMonth(let date):

Line should be 120 characters or less: currently 161 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            archivePathType = PathManager.userDefaults.archivePathType ?? .local(FileManager.default.documentsDirectoryURL.appendingPathComponent("PDFArchiver"))

Line should be 120 characters or less: currently 150 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            return NSLocalizedString("document_error_description__date_missing", comment: "No date could be found, e.g. while renaming the document.")

Line should be 120 characters or less: currently 165 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

        let paths = (try? FileManager.default.contentsOfDirectory(at: PathConstants.tempImageURL, includingPropertiesForKeys: nil, options: .skipsHiddenFiles)) ?? []

Variable name should be between 3 and 40 characters long: 'of'
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

    func startDownload(of: URL) throws

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .year(let date):

Line should be 120 characters or less: currently 157 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

        XCTAssert(fm.fileExists(at: destination.appendingPathComponent("subfolder").appendingPathComponent("subsubfolder").appendingPathComponent("file22")))

Line should be 120 characters or less: currently 131 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

                // this is disabled because it might cause unintended redirects, since the Sentry crash detection seems to be wonky
Severity: Minor
Found in Shared/PDFArchiverApp.swift by swiftlint

Line should be 120 characters or less: currently 155 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

    func windowScene(_ windowScene: UIWindowScene, performActionFor shortcutItem: UIApplicationShortcutItem, completionHandler: @escaping (Bool) -> Void) {
Severity: Minor
Found in Shared/PDFArchiverApp.swift by swiftlint

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .bundleVersionVerification:

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .hashValidation:

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .unableToLoadiTunesCertificate:

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .archive:

Case statements should vertically align with their enclosing switch statement.
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            case .tag:

Line should be 120 characters or less: currently 123 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

                log.errorAndAssert("Error while getting archive url.", metadata: ["error": "\(String(describing: error))"])

Type name should only contain alphanumeric characters: 'OBCardView_Previews'
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

struct OBCardView_Previews: PreviewProvider {

Line should be 120 characters or less: currently 150 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            return NSLocalizedString("document_error_description__tags_missing", comment: "No tags could be found, e.g. while renaming the document.")

Line should be 120 characters or less: currently 161 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

            return NSLocalizedString("document_failure_reason__description_missing", comment: "No description could be found, e.g. while renaming the document.")

Line should be 120 characters or less: currently 133 characters
Open
  • Open
  • Confirmed
  • Invalid
  • Wontfix
Cancel

//        let document = Document(path: path, downloadStatus: defaultDownloadStatus, taggingStatus: .untagged, byteSize: defaultSize)
Severity
Category