Sign upLogin

PHPOffice/PHPPresentation

View on GitHub
Star
src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php

Summary

Maintainability
F
1 wk
Test Coverage
C
70%

Function writeSlideRelationships has a Cognitive Complexity of 270 (exceeds 5 allowed). Consider refactoring.
Open

    protected function writeSlideRelationships(Slide $pSlide): string
    {
        //@todo Group all getShapeCollection()->getIterator

        // Create XML writer
Severity: Minor
Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 5 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method writeSlideRelationships has 182 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function writeSlideRelationships(Slide $pSlide): string
    {
        //@todo Group all getShapeCollection()->getIterator

        // Create XML writer
Severity: Major
Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 7 hrs to fix

    File PptSlides.php has 445 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This file is part of PHPPresentation - A pure PHP library for reading and writing
 * presentations documents.
 *
    Severity: Minor
    Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 6 hrs to fix

      Method writeSlideAnimations has 146 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function writeSlideAnimations(XMLWriter $objWriter, Slide $oSlide): void
    {
        $arrayAnimations = $oSlide->getAnimations();
        if (empty($arrayAnimations)) {
            return;
      Severity: Major
      Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 5 hrs to fix

        Method writeSlide has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function writeSlide(Slide $pSlide): string
    {
        // Create XML writer
        $objWriter = new XMLWriter(XMLWriter::STORAGE_MEMORY);
        Severity: Major
        Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 2 hrs to fix

          Function writeSlideAnimations has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function writeSlideAnimations(XMLWriter $objWriter, Slide $oSlide): void
    {
        $arrayAnimations = $oSlide->getAnimations();
        if (empty($arrayAnimations)) {
            return;
          Severity: Minor
          Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                          for ($cell = 0; $cell < $countCells; ++$cell) {
                                    $currentCell = $subShape->getRow($row)->getCell($cell);
                                    // Paragraphs in cell
                                    foreach ($currentCell->getParagraphs() as $paragraph) {
                                        // RichText in paragraph
          Severity: Major
          Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                                    if ($element->hasHyperlink()) {
                                            // Write relationship for hyperlink
                                            $hyperlink = $element->getHyperlink();
                                            $hyperlink->relationId = 'rId' . $relId;
            Severity: Major
            Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                                  if ($element instanceof Run || $element instanceof TextElement) {
                                        if ($element->hasHyperlink()) {
                                            // Write relationship for hyperlink
                                            $hyperlink = $element->getHyperlink();
                                            $hyperlink->relationId = 'rId' . $relId;
              Severity: Major
              Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 45 mins to fix

                Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function render(): ZipInterface
    {
        foreach ($this->oPresentation->getAllSlides() as $idx => $oSlide) {
            $this->oZip->addFromString('ppt/slides/_rels/slide' . ($idx + 1) . '.xml.rels', $this->writeSlideRelationships($oSlide));
            $this->oZip->addFromString('ppt/slides/slide' . ($idx + 1) . '.xml', $this->writeSlide($oSlide));
                Severity: Minor
                Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                        if ($subShape instanceof ShapeTable) {
                            // Rows
                            $countRows = count($subShape->getRows());
                            for ($row = 0; $row < $countRows; ++$row) {
                                // Cells in rows
                Severity: Major
                Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php and 1 other location - About 7 hrs to fix
                src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php on lines 182..214

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 244.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                if ($shape instanceof ShapeTable) {
                    // Rows
                    $countRows = count($shape->getRows());
                    for ($row = 0; $row < $countRows; ++$row) {
                        // Cells in rows
                Severity: Major
                Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php and 1 other location - About 7 hrs to fix
                src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php on lines 257..289

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 244.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                if ($shape instanceof RichText) {
                    foreach ($shape->getParagraphs() as $paragraph) {
                        foreach ($paragraph->getRichTextElements() as $element) {
                            if ($element instanceof Run || $element instanceof TextElement) {
                                if ($element->hasHyperlink()) {
                Severity: Major
                Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php and 1 other location - About 3 hrs to fix
                src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php on lines 234..254

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 149.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                        if ($subShape instanceof RichText) {
                            foreach ($subShape->getParagraphs() as $paragraph) {
                                foreach ($paragraph->getRichTextElements() as $element) {
                                    if ($element instanceof Run || $element instanceof TextElement) {
                                        if ($element->hasHyperlink()) {
                Severity: Major
                Found in src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php and 1 other location - About 3 hrs to fix
                src/PhpPresentation/Writer/PowerPoint2007/PptSlides.php on lines 159..179

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 149.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status