Sign upLogin

PHPSocialNetwork/phpfastcache-bundle

View on GitHub
Star

Showing 43 of 43 total issues

Method indexAction has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function indexAction(Request $request, Phpfastcache $phpfastcache)
    {
        $pfc_test = null;

        $cache = $phpfastcache->get('filecache');
Severity: Major
Found in src/Resources/Docs/example/Controller/DefaultController.php - About 3 hrs to fix

    Function execute has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
    {
        $failedInstances = [];
        $io = new SymfonyStyle($input, $output);
    Severity: Minor
    Found in src/Command/PhpfastcacheClearCommand.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function get(string $name): ExtendedCacheItemPoolInterface
    {
        if ($this->stopwatch) {
            $this->stopwatch->start(__METHOD__ . "('{$name}')");
        }
    Severity: Minor
    Found in src/Service/Phpfastcache.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function indexAction has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function indexAction(Request $request, Phpfastcache $phpfastcache)
    {
        $pfc_test = null;

        $cache = $phpfastcache->get('filecache');
    Severity: Minor
    Found in src/Resources/Docs/example/Controller/DefaultController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
    {
        $failedInstances = [];
        $io = new SymfonyStyle($input, $output);
    Severity: Minor
    Found in src/Command/PhpfastcacheClearCommand.php - About 1 hr to fix

      Method execute has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function execute(InputInterface $input, OutputInterface $output)
    {
        $io = new SymfonyStyle($input, $output);
        $caches = $this->parameters;
      Severity: Minor
      Found in src/Command/PhpfastcacheSetCommand.php - About 1 hr to fix

        Method collect has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function collect(Request $request, Response $response, \Exception $exception = null)
    {
        $size = 0;
        $stats = [];
        $instances = [];
        Severity: Minor
        Found in src/DataCollector/CacheCollector.php - About 1 hr to fix

          Function execute has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function execute(InputInterface $input, OutputInterface $output)
    {
        $io = new SymfonyStyle($input, $output);
        $caches = $this->parameters;
          Severity: Minor
          Found in src/Command/PhpfastcacheSetCommand.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method get has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get(string $name): ExtendedCacheItemPoolInterface
    {
        if ($this->stopwatch) {
            $this->stopwatch->start(__METHOD__ . "('{$name}')");
        }
          Severity: Minor
          Found in src/Service/Phpfastcache.php - About 1 hr to fix

            Method configure has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function configure()
    {
        $this
          ->setName('phpfastcache:set')
          ->setDescription('Set phpfastcache cache value')
            Severity: Minor
            Found in src/Command/PhpfastcacheSetCommand.php - About 1 hr to fix

              Method compile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function compile(\Twig_Compiler $compiler)
    {
        $i = self::$cacheCount++;

        if (\version_compare(\Twig_Environment::VERSION, '1.26.0', '>=')) {
              Severity: Minor
              Found in src/Twig/CacheExtension/Node/CacheNode.php - About 1 hr to fix

                Function execute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $io = new SymfonyStyle($input, $output);
        $caches = $this->parameters;
                Severity: Minor
                Found in src/Command/PhpfastcacheGetCommand.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid variables with short names like $sz. Configured minimum length is 3.
                Open

                        $sz = 'BKMGTP';
                Severity: Minor
                Found in src/Twig/HumanReadableExtension/Extension.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                Avoid variables with short names like $io. Configured minimum length is 3.
                Open

                        $io = new SymfonyStyle($input, $output);
                Severity: Minor
                Found in src/Command/PhpfastcacheDelCommand.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                Avoid variables with short names like $io. Configured minimum length is 3.
                Open

                        $io = new SymfonyStyle($input, $output);
                Severity: Minor
                Found in src/Command/PhpfastcacheClearCommand.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                Avoid variables with short names like $i. Configured minimum length is 3.
                Open

                        $i = self::$cacheCount++;
                Severity: Minor
                Found in src/Twig/CacheExtension/Node/CacheNode.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                The property $twig_cache_blocks is not named in camelCase.
                Open

                class CacheCollector extends DataCollector
{
    /**
     * @var \Phpfastcache\Bundle\Service\Phpfastcache
     */
                Severity: Minor
                Found in src/DataCollector/CacheCollector.php by phpmd

                CamelCasePropertyName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name attributes.

                Example

                class ClassName {
    protected $property_name;
}

                Source

                Avoid variables with short names like $io. Configured minimum length is 3.
                Open

                        $io = new SymfonyStyle($input, $output);
                Severity: Minor
                Found in src/Command/PhpfastcacheSetCommand.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                Avoid variables with short names like $io. Configured minimum length is 3.
                Open

                        $io = new SymfonyStyle($input, $output);
                Severity: Minor
                Found in src/Command/PhpfastcacheGetCommand.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function __construct(\Twig_Node_Expression $annotation, \Twig_Node_Expression $keyInfo, \Twig_Node $body, $lineno, $tag = null)
                Severity: Minor
                Found in src/Twig/CacheExtension/Node/CacheNode.php - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language