Sign upLogin

PHPixie/ORM

View on GitHub
Star

Showing 120 of 120 total issues

Method in has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function in($query, $queryField, $subquery, $subqueryField, $plan, $logic = 'and', $negate = false)
Severity: Major
Found in src/PHPixie/ORM/Planners/Planner/In/Strategy/Multiquery.php - About 50 mins to fix

    Method in has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        abstract public function in($query, $queryField, $subquery, $subqueryField, $plan, $logic = 'and', $negate = false);
    Severity: Major
    Found in src/PHPixie/ORM/Planners/Planner/In/Strategy.php - About 50 mins to fix

      Method databaseModelQuery has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function databaseModelQuery($query, $queryField, $modelQuery, $modelQueryField, $plan, $logic = 'and', $negate = false)
      Severity: Major
      Found in src/PHPixie/ORM/Planners/Planner/In.php - About 50 mins to fix

        Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct($configs, $models, $planners, $plans, $steps, $loaders, $mappers)
        Severity: Major
        Found in src/PHPixie/ORM/Relationships/Relationship/Implementation.php - About 50 mins to fix

          Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function __construct($models, $planners, $plans, $steps, $loaders, $mappers, $relationship)
          Severity: Major
          Found in src/PHPixie/ORM/Relationships/Relationship/Implementation/Handler.php - About 50 mins to fix

            Method itemIds has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function itemIds($query, $queryField, $repository, $items, $plan, $logic = 'and', $negate = false)
            Severity: Major
            Found in src/PHPixie/ORM/Planners/Planner/In.php - About 50 mins to fix

              Method preloader has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function preloader($side, $modelConfig, $result, $loader, $parentResult, $relatedLoader)
              Severity: Minor
              Found in src/PHPixie/ORM/Relationships/Type/NestedSet.php - About 45 mins to fix

                Method processProperty has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    protected function processProperty($type, $config, $entity, $action, $value = null, $unsetRelated = true)
                Severity: Minor
                Found in src/PHPixie/ORM/Relationships/Type/OneTo/Type/One/Handler.php - About 45 mins to fix

                  Method items has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function items($query, $modelName, $items, $plan, $logic = 'and', $negate = false)
                  Severity: Minor
                  Found in src/PHPixie/ORM/Planners/Planner/In.php - About 45 mins to fix

                    Method map has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function map($preloadable, $modelName, $preload, $result, $plan, $loader)
                    Severity: Minor
                    Found in src/PHPixie/ORM/Mappers/Preload.php - About 45 mins to fix

                      Function offsetExists has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function offsetExists($offset)
    {
        if($this->currentOffset === $offset)
            return true;
                      Severity: Minor
                      Found in src/PHPixie/ORM/Loaders/Loader/Repository/DataIterator.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function __construct($loaders, $side, $modelConfig, $result, $loader, $pivotResult)
                      Severity: Minor
                      Found in src/PHPixie/ORM/Relationships/Type/ManyToMany/Preloader.php - About 45 mins to fix

                        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function __construct($mappers, $relationships, $models, $planners, $steps, $cascadeDeletMap)
                        Severity: Minor
                        Found in src/PHPixie/ORM/Mappers/Cascade/Mapper/Delete.php - About 45 mins to fix

                          Function execute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function execute()
    {
        $fields = array(
            $rootIdKey = $this->config->rootIdKey,
            $leftKey = $this->config->leftKey,
                          Severity: Minor
                          Found in src/PHPixie/ORM/Relationships/Type/NestedSet/Steps/MapQuery.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function mapConditions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function mapConditions($builder, $modelName, $conditions, $plan)
    {
        foreach ($conditions as $condition) {
   
            if ($condition instanceof \PHPixie\ORM\Conditions\Condition\Field\Operator) {
                          Severity: Minor
                          Found in src/PHPixie/ORM/Mappers/Conditions.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function processConfig has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function processConfig($configSlice, $inflector)
    {
        $sides = array('left' => 'right', 'right' => 'left');

        foreach ($sides as $side) {
                          Severity: Minor
                          Found in src/PHPixie/ORM/Relationships/Type/ManyToMany/Side/Config.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function updateSkippedOffsets has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function updateSkippedOffsets()
    {
        $skippedOffsets = array();
        foreach($this->skippedIds as $skippedOffset)
            if($skippedOffset!==null)
                          Severity: Minor
                          Found in src/PHPixie/ORM/Loaders/Loader/Proxy/Editable.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method getUnlinkPlan has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              protected function getUnlinkPlan($config, $constrainOwners, $owners, $constrainItems, $items, $logic = 'and')
                          Severity: Minor
                          Found in src/PHPixie/ORM/Relationships/Type/OneTo/Handler.php - About 45 mins to fix

                            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                public function __construct($loaders, $embeddedModel, $modelName, $arrayNode, $owner, $ownerPropertyName)
                            Severity: Minor
                            Found in src/PHPixie/ORM/Loaders/Loader/Embedded/ArrayNode.php - About 45 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  public function __construct($models, $planners, $plans, $steps, $loaders, $mappers, $relationship)
    {
        $this->models             = $models;
        $this->planners           = $planners;
        $this->plans              = $plans;
                              Severity: Minor
                              Found in src/PHPixie/ORM/Relationships/Relationship/Implementation/Handler.php and 1 other location - About 45 mins to fix
                              src/PHPixie/ORM/Relationships/Relationship/Implementation.php on lines 17..26

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 95.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language