Sign upLogin

PabloKowalczyk/SupercacheBundle

View on GitHub
Star
src/Cache/ResponseHandler.php

Summary

Maintainability
A
2 hrs
Test Coverage
D
65%

Function isCacheable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function isCacheable(Request $request, Response $response)
    {
        if (!$this->supercacheEnabled) {
            return CacheManager::UNCACHEABLE_DISABLED;
        }
Severity: Minor
Found in src/Cache/ResponseHandler.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/Cache/ResponseHandler.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return CacheManager::UNCACHEABLE_PRIVATE;
    Severity: Major
    Found in src/Cache/ResponseHandler.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return CacheManager::UNCACHEABLE_NO_STORE_POLICY;
      Severity: Major
      Found in src/Cache/ResponseHandler.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return CacheManager::UNCACHEABLE_CODE;
        Severity: Major
        Found in src/Cache/ResponseHandler.php - About 30 mins to fix

          Reduce the number of returns of this function 8, down to the maximum allowed 3.
          Open

              public function isCacheable(Request $request, Response $response)
          Severity: Major
          Found in src/Cache/ResponseHandler.php by sonar-php

          Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

          Noncompliant Code Example

          With the default threshold of 3:

          function myFunction(){ // Noncompliant as there are 4 return statements
  if (condition1) {
    return true;
  } else {
    if (condition2) {
      return false;
    } else {
      return true;
    }
  }
  return false;
}

          There are no issues that match your filters.

          Category
          Status