Sign upLogin

ParentSquare/faulty

View on GitHub
Star
lib/faulty/storage/redis.rb

Summary

Maintainability
C
7 hrs
Test Coverage
A
95%

Class Redis has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Redis
      # Separates the time/status for history entry strings
      ENTRY_SEPARATOR = ':'

      attr_reader :options
Severity: Minor
Found in lib/faulty/storage/redis.rb - About 4 hrs to fix

    Method check_redis_options! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_redis_options!
        gte5 = ::Redis::VERSION.to_f >= 5
        method = gte5 ? :config : :options
        ropts = redis do |r|
          r.instance_variable_get(:@client).public_send(method)
    Severity: Minor
    Found in lib/faulty/storage/redis.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method entry has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def entry(circuit, time, success, status)
        key = entries_key(circuit.name)
        result = pipe do |r|
          r.call([:sadd, list_key, circuit.name])
          r.expire(list_key, options.circuit_ttl + options.list_granularity) if options.circuit_ttl
    Severity: Minor
    Found in lib/faulty/storage/redis.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status