Sign upLogin

PascalHonegger/M151

View on GitHub
Star
Login/RegisterController.php

Summary

Maintainability
A
1 hr
Test Coverage

Method registerPerson has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function registerPerson(string $username, string $password, string $repeatPassword, string $surname, string $name, string $mail)
Severity: Minor
Found in Login/RegisterController.php - About 45 mins to fix

    Method inputValid has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static function inputValid(string $username, string $password, string $repeatPassword, string $surname, string $name, string $mail)
    Severity: Minor
    Found in Login/RegisterController.php - About 45 mins to fix

      Function registerPerson has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function registerPerson(string $username, string $password, string $repeatPassword, string $surname, string $name, string $mail)
    {
        $validationResults = $this->inputValid($username, $password, $repeatPassword, $surname, $name, $mail);

        $allValid = true;
      Severity: Minor
      Found in Login/RegisterController.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Missing class import via use statement (line '24', column '28').
      Open

              $this->model = new RegisterModel();
      Severity: Minor
      Found in Login/RegisterController.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid using static access to class 'CustomSession' in method '__construct'.
      Open

              $this->session = CustomSession::getInstance();
      Severity: Minor
      Found in Login/RegisterController.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid excessively long variable names like $passwordRegularExpression. Keep variable name length under 20.
      Open

          private static $passwordRegularExpression = '/^(?=.*[a-z])(?=.*[A-Z])(?=.*\d)(?=.*[$@!%*?&_-])[A-Za-z\d$@!%*?&_-]{8,}/';
      Severity: Minor
      Found in Login/RegisterController.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      There are no issues that match your filters.

      Category
      Status