Sign upLogin

Perlmint/directory-module-webpack-plugin

View on GitHub
Star

Showing 8 of 8 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (statStorageIsMap) { // enhanced-resolve@3.4.0 or greater
            fs._statStorage.data.set(outPath, [null, stats]);
        } else { // enhanced-resolve@3.3.0 or lower
            fs._statStorage.data[outPath] = [null, stats];
        }
Severity: Major
Found in src/plugin.ts and 1 other location - About 1 hr to fix
src/plugin.ts on lines 147..151

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (readFileStorageIsMap) { // enhanced-resolve@3.4.0 or greater
            fs._readFileStorage.data.set(outPath, [null, contents]);
        } else { // enhanced-resolve@3.3.0 or lower
            fs._readFileStorage.data[outPath] = [null, contents];
        }
Severity: Major
Found in src/plugin.ts and 1 other location - About 1 hr to fix
src/plugin.ts on lines 142..146

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function create has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static create(options: StatsCreateOption) {
        if (!options) {
            options = {};
        }
        if (!options.ctime) {
Severity: Minor
Found in src/virtualStats.ts - About 1 hr to fix

    Function populateFilesystem has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private async populateFilesystem(fs: any, modulePath: string, outPath: string, emitType: EmitType) {
        const mapIsAvailable = typeof Map !== "undefined";
        const statStorageIsMap = mapIsAvailable && fs._statStorage.data instanceof Map;
        const readFileStorageIsMap = mapIsAvailable && fs._readFileStorage.data instanceof Map;
    Severity: Minor
    Found in src/plugin.ts - About 1 hr to fix

      Function populateFilesystem has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          private async populateFilesystem(fs: any, modulePath: string, outPath: string, emitType: EmitType) {
        const mapIsAvailable = typeof Map !== "undefined";
        const statStorageIsMap = mapIsAvailable && fs._statStorage.data instanceof Map;
        const readFileStorageIsMap = mapIsAvailable && fs._readFileStorage.data instanceof Map;
      Severity: Minor
      Found in src/plugin.ts - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function beforeResolve has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private static async beforeResolve(
        this: any, plugin: DirectoryModulePlugin, data: IResolveRequest, callback: IBeforeResolveRequestCallback,
    ) {
        if (plugin.populatedDirectories[data.request]) {
            data.request = plugin.populatedDirectories[data.request];
      Severity: Minor
      Found in src/plugin.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static create(options: StatsCreateOption) {
        if (!options) {
            options = {};
        }
        if (!options.ctime) {
      Severity: Minor
      Found in src/virtualStats.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Array type using 'Array<t>' is forbidden. Use 'T[]' instead.</t>
      Open

      export type InternalOption = Array < [RegExp, EmitType] > ;
      Severity: Minor
      Found in src/option.ts by tslint

      Rule: array-type

      Requires using either 'T[]' or 'Array<t>' for arrays.</t>

      Notes
      • TypeScript Only
      • Has Fix

      Config

      One of the following arguments must be provided:

      • "array" enforces use of T[] for all types T.
      • "generic" enforces use of Array<T> for all types T.
      • "array-simple" enforces use of T[] if T is a simple type (primitive or type reference).
      Examples
      "array-type": true,array
      "array-type": true,generic
      "array-type": true,array-simple
      Schema
      {
  "type": "string",
  "enum": [
    "array",
    "generic",
    "array-simple"
  ]
}

      For more information see this page.

      Severity
      Category
      Status
      Source
      Language