Sign upLogin

Ph0tonic/SDP_Projet

View on GitHub
Star
app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt

Summary

Maintainability
A
0 mins
Test Coverage
B
86%

Method getGroupIdsOfUserByEmail has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    override fun getGroupIdsOfUserByEmail(email: String): LiveData<Map<String, Role>> {
        if (!userIdGroups.containsKey(email)) {
            //Initialise data
            val myRef = database.getReference(ROOT_PATH)
            userIdGroups[email] = MutableLiveData(mapOf())
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt - About 1 hr to fix

    Method getUsersOfGroupWithRole has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        override fun getUsersOfGroupWithRole(groupId: String, role: Role): LiveData<Set<UserData>> {
        val mapData = if (role == Role.OPERATOR) groupOperators else groupRescuers

        if (!mapData.containsKey(groupId)) {
            //Initialise data
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt - About 1 hr to fix

      Method getGroupIdsOfUserByEmail has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Wontfix

          override fun getGroupIdsOfUserByEmail(email: String): LiveData<Map<String, Role>> {
        if (!userIdGroups.containsKey(email)) {
            //Initialise data
            val myRef = database.getReference(ROOT_PATH)
            userIdGroups[email] = MutableLiveData(mapOf())
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Wontfix

                          if (user != null) {
                        userIdGroups[email]?.value = userIdGroups[email]?.value!!.plus(Pair(dataSnapshot.key!!, user.role))
                    }
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt and 1 other location - About 1 hr to fix
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt on lines 44..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Wontfix

                          val user = dataSnapshot.children.map {
                        it.getValue(UserData::class.java)!!
                    }.find { it.email == email }
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt and 1 other location - About 1 hr to fix
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt on lines 40..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Wontfix

                          if (user != null) {
                        userIdGroups[email]?.value = userIdGroups[email]?.value!!.plus(Pair(dataSnapshot.key!!, user.role))
                    } else {
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt and 1 other location - About 1 hr to fix
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt on lines 56..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Wontfix

                          val user = dataSnapshot.children.map {
                        it.getValue(UserData::class.java)!!
                    }.find { it.email == email }
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt and 1 other location - About 1 hr to fix
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt on lines 52..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Wontfix

          private val groupRescuers: MutableMap<String, MutableLiveData<Set<UserData>>> = mutableMapOf()
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt and 3 other locations - About 40 mins to fix
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseMarkersDao.kt on lines 21..21
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt on lines 23..23
      app/src/main/java/ch/epfl/sdp/database/dao/OfflineMarkerDao.kt on lines 12..12

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Wontfix

          private val groupOperators: MutableMap<String, MutableLiveData<Set<UserData>>> = mutableMapOf()
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt and 3 other locations - About 40 mins to fix
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseMarkersDao.kt on lines 21..21
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt on lines 24..24
      app/src/main/java/ch/epfl/sdp/database/dao/OfflineMarkerDao.kt on lines 12..12

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Wontfix

          override fun removeAllUserOfSearchGroup(searchGroupId: String) {
        database.getReference("$ROOT_PATH/${searchGroupId}").removeValue()
    }
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/database/dao/FirebaseUserDao.kt and 3 other locations - About 30 mins to fix
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseGroupDao.kt on lines 80..82
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseHeatmapDao.kt on lines 30..32
      app/src/main/java/ch/epfl/sdp/database/dao/FirebaseMarkersDao.kt on lines 63..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status