Sign upLogin

Pi2-FGABreja/FGABrejaWeb

View on GitHub
Star
FGABreja/monitoring/states.py

Summary

Maintainability
A
2 hrs
Test Coverage

Avoid too many return statements within this function.
Open

        return "Fermentation"
Severity: Major
Found in FGABreja/monitoring/states.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return "Cooling"
    Severity: Major
    Found in FGABreja/monitoring/states.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return COOLING.get(state)
      Severity: Major
      Found in FGABreja/monitoring/states.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return FERMENTATION.get(state)
        Severity: Major
        Found in FGABreja/monitoring/states.py - About 30 mins to fix

          Function get_stage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def get_stage(state):
    if state in PREBREWERY.values():
        return "Pre-brewery"
    elif state in BREWERY.values():
        return "Brewery"
          Severity: Minor
          Found in FGABreja/monitoring/states.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function get_state has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def get_state(state):
    if state in PREBREWERY.keys():
        return PREBREWERY.get(state)
    elif state in BREWERY.keys():
        return BREWERY.get(state)
          Severity: Minor
          Found in FGABreja/monitoring/states.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status