Sign upLogin

Pink-Crab/Perique-Registerables

View on GitHub
Star

Showing 12 of 14 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php


declare(strict_types=1);
Severity: Major
Found in src/Validator/Post_Type_Validator.php and 1 other location - About 5 hrs to fix
src/Validator/Taxonomy_Validator.php on lines 1..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 200.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php


declare(strict_types=1);
Severity: Major
Found in src/Validator/Taxonomy_Validator.php and 1 other location - About 5 hrs to fix
src/Validator/Post_Type_Validator.php on lines 1..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 200.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $hierarchical_labels = array(
            /* translators: %s: Taxonomy singular name */
            'parent_item_colon' => wp_sprintf( _x( 'Parent %s:', 'Label used to prefix parents of hierarchical items. Not used on non-hierarchical taxonomys. Default is ‘Parent {taxonomy plural name}:’.', 'pinkcrab' ), \esc_attr( $taxonomy->singular ?? '' ) ),
            /* translators: %s: Taxonomy singular name */
            'parent_item'       => wp_sprintf( _x( 'Parent %s', 'Label for the parent term', 'pinkcrab' ), \esc_attr( $taxonomy->singular ?? '' ) ),
Severity: Major
Found in src/Registrar/Taxonomy_Registrar.php and 1 other location - About 2 hrs to fix
src/Registrar/Taxonomy_Registrar.php on lines 152..159

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $tag_labels = array(
            /* translators: %s: Taxonomy plural name */
            'separate_items_with_commas' => wp_sprintf( _x( 'Separate %s with commas', 'This label is only used for non-hierarchical taxonomies. Default \'Separate {taxonomy plural name} with commas\', used in the meta box.’.', 'pinkcrab' ), \esc_attr( $taxonomy->plural ?? '' ) ),
            /* translators: %s: Taxonomy plural name */
            'add_or_remove_items'        => wp_sprintf( _x( 'Add or remove %s', 'This label is only used for non-hierarchical taxonomies. Default \'Add or remove {taxonomy plural name}\', used in the meta box when JavaScript is disabled.', 'pinkcrab' ), \esc_attr( $taxonomy->plural ?? '' ) ),
Severity: Major
Found in src/Registrar/Taxonomy_Registrar.php and 1 other location - About 2 hrs to fix
src/Registrar/Taxonomy_Registrar.php on lines 161..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Meta_Data has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class Meta_Data {
    /**
     * Object type meta applies to
     *
     * @var string
Severity: Minor
Found in src/Meta_Data.php - About 2 hrs to fix

    Method register has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function register( Registerable $registerable ): void {
        if ( ! is_a( $registerable, Additional_Meta_Data_Controller::class ) ) {
            throw new Exception( 'Registerable must be an instance of Additional_Meta_Data_Controller' );
        }
    Severity: Minor
    Found in src/Registrar/Additional_Meta_Data_Registrar.php - About 1 hr to fix

      Method register has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register( Meta_Box $meta_box ): void {

        if ( ! $this->validator->verify_meta_box( $meta_box ) ) {
            throw new Exception(
                sprintf(
      Severity: Minor
      Found in src/Registrar/Meta_Box_Registrar.php - About 1 hr to fix

        Function register has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function register( Registerable $registerable ): void {
        if ( ! is_a( $registerable, Additional_Meta_Data_Controller::class ) ) {
            throw new Exception( 'Registerable must be an instance of Additional_Meta_Data_Controller' );
        }
        Severity: Minor
        Found in src/Registrar/Additional_Meta_Data_Registrar.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method process_post_type has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function process_post_type( Post_Type $post_type_registerable ) {
        // Register registerable.
        $this->loader->action(
            'init',
            static function() use ( $post_type_registerable ) {
        Severity: Minor
        Found in src/Module/Middleware/Registerable_Middleware.php - About 1 hr to fix

          Function process has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function process( object $class ): object {
        if ( ! is_a( $class, Registerable::class ) ) {
            return $class;
        }
          Severity: Minor
          Found in src/Module/Middleware/Registerable_Middleware.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function create_rest_update_method has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function create_rest_update_method( Meta_Data $meta ): \Closure {
        /**
         * @param mixed $value
         * @param \WP_Post|\WP_Term|\WP_User|\WP_Comment $object
         */
          Severity: Minor
          Found in src/Registrar/Meta_Data_Registrar.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function create_rest_get_method has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function create_rest_get_method( Meta_Data $meta ): callable {
        return function( $model ) use ( $meta ) {
            switch ( $meta->get_meta_type() ) {
                case 'post':
                    $value = get_post_meta( $model['id'], $meta->get_meta_key(), true );
          Severity: Minor
          Found in src/Registrar/Meta_Data_Registrar.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language