Sign upLogin

Platoniq/decidim-verifications-direct_verifications

View on GitHub
Star

Showing 9 of 9 total issues

Method authorized_users has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def authorized_users(strict: true)
        q = Decidim::Authorization.joins(:user)
        unless authorization_handler.empty?
          q = q.where(name: authorization_handler)
          if strict
Severity: Minor
Found in lib/decidim/direct_verifications/user_stats.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def initialize(email, data, session, organization, instrumenter, authorization_handler)
Severity: Minor
Found in lib/decidim/direct_verifications/authorize_user.rb - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              def revoke_users
            return unless params[:authorize] == "out"

            @processor.revoke_users
            flash[:notice] = t(".revoked", handler: t("#{@processor.authorization_handler}.name", scope: "decidim.authorization_handlers"),
    Severity: Minor
    Found in app/controllers/decidim/direct_verifications/verification/admin/direct_verifications_controller.rb and 1 other location - About 45 mins to fix
    app/controllers/decidim/direct_verifications/verification/admin/direct_verifications_controller.rb on lines 56..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              def authorize_users
            return unless params[:authorize] == "in"

            @processor.authorize_users
            flash[:notice] = t(".authorized", handler: t("#{@processor.authorization_handler}.name", scope: "decidim.authorization_handlers"),
    Severity: Minor
    Found in app/controllers/decidim/direct_verifications/verification/admin/direct_verifications_controller.rb and 1 other location - About 45 mins to fix
    app/controllers/decidim/direct_verifications/verification/admin/direct_verifications_controller.rb on lines 66..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 39.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method perform has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def perform(blob_id, organization, current_user, authorization_handler, options = {})
    Severity: Minor
    Found in app/jobs/decidim/direct_verifications/base_import_job.rb - About 35 mins to fix

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def initialize(email, data, organization, current_user, instrumenter)
      Severity: Minor
      Found in lib/decidim/direct_verifications/register_user.rb - About 35 mins to fix

        Method permissions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def permissions
          return permission_action if permission_action.scope != :admin
          return permission_action unless user
          return permission_action unless user.admin?
        Severity: Minor
        Found in app/permissions/decidim/direct_verifications/admin/permissions.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def call
        return if user

        InviteUser.call(form) do
          on(:ok) do
        Severity: Minor
        Found in lib/decidim/direct_verifications/register_user.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def parse_data(email, line, header)
          tokens = tokenize(line)

          hash = {}
          header.each_with_index do |column, index|
        Severity: Minor
        Found in lib/decidim/direct_verifications/parsers/metadata_parser.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language