Sign upLogin

Platoniq/decidim-verifications-direct_verifications

View on GitHub
Star

Showing 7 of 9 total issues

Method authorized_users has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def authorized_users(strict: true)
        q = Decidim::Authorization.joins(:user)
        unless authorization_handler.empty?
          q = q.where(name: authorization_handler)
          if strict
Severity: Minor
Found in lib/decidim/direct_verifications/user_stats.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def initialize(email, data, session, organization, instrumenter, authorization_handler)
Severity: Minor
Found in lib/decidim/direct_verifications/authorize_user.rb - About 45 mins to fix

    Method perform has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def perform(blob_id, organization, current_user, authorization_handler, options = {})
    Severity: Minor
    Found in app/jobs/decidim/direct_verifications/base_import_job.rb - About 35 mins to fix

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def initialize(email, data, organization, current_user, instrumenter)
      Severity: Minor
      Found in lib/decidim/direct_verifications/register_user.rb - About 35 mins to fix

        Method permissions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def permissions
          return permission_action if permission_action.scope != :admin
          return permission_action unless user
          return permission_action unless user.admin?
        Severity: Minor
        Found in app/permissions/decidim/direct_verifications/admin/permissions.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def call
        return if user

        InviteUser.call(form) do
          on(:ok) do
        Severity: Minor
        Found in lib/decidim/direct_verifications/register_user.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def parse_data(email, line, header)
          tokens = tokenize(line)

          hash = {}
          header.each_with_index do |column, index|
        Severity: Minor
        Found in lib/decidim/direct_verifications/parsers/metadata_parser.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language