Sign upLogin

Pojostick/ipsr-mosaic

View on GitHub
Star

Showing 8 of 8 total issues

Method gallery has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def gallery
    # renders the collection of galleries to be viewed by researchers
    if !params[:checked].nil?
      # @checked_mosaics = params[:checked].split(" ").map { |s| s.to_i }
      @checked_mosaics = params[:checked]
Severity: Minor
Found in app/controllers/mosaics_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function undo has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    var undo = function(instant) {
        if (current >= 0) {
            var records = stepRecord[current];
            for (var key in records) {
                var record = records[key];
Severity: Minor
Found in app/assets/javascripts/mosaics_show.js - About 1 hr to fix

Function redo has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    var redo = function(instant) {
        if (current < stepRecord.length - 1) {
            current++;
            var records = stepRecord[current];
            for (var key in records) {
Severity: Minor
Found in app/assets/javascripts/mosaics_show.js - About 1 hr to fix

Method autosave has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def autosave
    @mosaic = Mosaic.find params[:mosaic_id]
    return if @mosaic.time_taken > -1
    if params[:time_taken]
      @mosaic.update_attributes!({:time_taken => params[:time_taken].to_i, :time_left => 0, :time_submitted => Time.now})
Severity: Minor
Found in app/controllers/mosaics_controller.rb - About 1 hr to fix

Method autosave has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def autosave
    @mosaic = Mosaic.find params[:mosaic_id]
    return if @mosaic.time_taken > -1
    if params[:time_taken]
      @mosaic.update_attributes!({:time_taken => params[:time_taken].to_i, :time_left => 0, :time_submitted => Time.now})
Severity: Minor
Found in app/controllers/mosaics_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Step has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    var Step = function(tile, ax, ay, az, bx, by, bz, instant) {
Severity: Major
Found in app/assets/javascripts/mosaics_show.js - About 1 hr to fix

Function render has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    var render = function(display, max, low, high, units) {
Severity: Minor
Found in app/assets/javascripts/gallery.js - About 35 mins to fix

Method new has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def new
    @width = 10
    @height = 8
    @time_total = 30
    render "new" and return if not (params[:width] and params[:height] and params[:time])
Severity: Minor
Found in app/controllers/mosaics_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language