Sign upLogin

PolyBooks/sdp_polyBooks

View on GitHub
Star

Showing 76 of 93 total issues

Method parseBook has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    /**
     * Function for internal use in OLBookDatabase. Takes the json of a book, and makes a Book from it.
     * */
    @RequiresApi(Build.VERSION_CODES.N)
    private fun parseBook(jsonBook: JsonElement): Book {
Severity: Minor
Found in app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt - About 1 hr to fix

    Method scanBarcodes has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            // Inspired from the library guide : https://developers.google.com/ml-kit/vision/barcode-scanning/android#kotlin
        @SuppressLint("UnsafeExperimentalUsageError")
        private fun scanBarcodes(imageProxy: ImageProxy) {

            val mediaImage = imageProxy.image
    Severity: Minor
    Found in app/src/main/java/com/github/polybooks/activities/ScanBarcodeActivity.kt - About 1 hr to fix

      Method takePhoto has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          fun takePhoto(view: View) {
        // TODO offer flash option and other quality of life upgrades

        // Get a stable reference of the modifiable image capture use case
        val imageCapture = imageCapture ?: return
      Severity: Minor
      Found in app/src/main/java/com/github/polybooks/activities/TakeBookPictureActivity.kt - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    ?.let {
                val languageOption = getJsonField(asJsonObject(it), "key")
                val languageJson =
                    languageOption.orElseThrow(cantParseException("$LANGUAGE_FIELD_NAME[0].key"))
                asString(languageJson)
        Severity: Major
        Found in app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt and 1 other location - About 1 hr to fix
        app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt on lines 177..182

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    .map {
                val authorOption = getJsonField(asJsonObject(it), "key")
                val authorJson =
                    authorOption.orElseThrow(cantParseException("$AUTHORS_FIELD_NAME[n].key"))
                asString(authorJson)
        Severity: Major
        Found in app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt and 1 other location - About 1 hr to fix
        app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt on lines 190..195

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method setupNavbar has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        fun setupNavbar(
    navBar: BottomNavigationView,
    origin: Context,
    selectedItem: Int = R.id.default_selected,
    selectedListener: BottomNavigationView.OnNavigationItemSelectedListener? = null
        Severity: Minor
        Found in app/src/main/java/com/github/polybooks/utils/NavBarCreation.kt - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                  bookRating.uploadToFirebase(sale.book.isbn).thenApply {
                            Toast.makeText(this, "You chose : $rating stars", Toast.LENGTH_SHORT).show()
                        }
          Severity: Major
          Found in app/src/main/java/com/github/polybooks/activities/SaleInformationActivity.kt and 1 other location - About 1 hr to fix
          app/src/main/java/com/github/polybooks/activities/SaleInformationActivity.kt on lines 103..105

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                                      bookRating.uploadToFirebase(sale.book.isbn).thenApply {
                                Toast.makeText(this, "You chose : $rating stars", Toast.LENGTH_SHORT).show()
                            }
          Severity: Major
          Found in app/src/main/java/com/github/polybooks/activities/SaleInformationActivity.kt and 1 other location - About 1 hr to fix
          app/src/main/java/com/github/polybooks/activities/SaleInformationActivity.kt on lines 121..123

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method setParametersButtons has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private fun setParametersButtons() {
        setTextParameters()

        mSortParameter = Parameter(
            R.id.sale_sort_parameter,
          Severity: Minor
          Found in app/src/main/java/com/github/polybooks/activities/FilteringSalesActivity.kt - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private fun asJsonArray(jsonElement: JsonElement): JsonArray {
        if (!jsonElement.isJsonArray) {
            throw DatabaseException(errorMessage + "Json is not a JsonArray")
        }
        return jsonElement.asJsonArray!!
            Severity: Major
            Found in app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt and 1 other location - About 1 hr to fix
            app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt on lines 219..224

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private fun asJsonObject(jsonElement: JsonElement): JsonObject {
        if (!jsonElement.isJsonObject) {
            throw DatabaseException(errorMessage + "Json is not a JsonObject")
        }
        return jsonElement.asJsonObject!!
            Severity: Major
            Found in app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt and 1 other location - About 1 hr to fix
            app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt on lines 226..231

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private fun parseLanguage(jsonLanguage: JsonElement): String {
        val nameField = getJsonField(asJsonObject(jsonLanguage), LANGUAGE_NAME_FIELD_NAME)
        return nameField.map { asString(it) }.orElseThrow(
            cantParseException(
                LANGUAGE_NAME_FIELD_NAME
            Severity: Major
            Found in app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt and 1 other location - About 1 hr to fix
            app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt on lines 145..149

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private fun parseAuthor(jsonAuthor: JsonElement): String {
        val nameField = getJsonField(asJsonObject(jsonAuthor), AUTHOR_NAME_FIELD_NAME)
        return nameField.map { asString(it) }
            .orElseThrow(cantParseException(AUTHOR_NAME_FIELD_NAME))
    }
            Severity: Major
            Found in app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt and 1 other location - About 1 hr to fix
            app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt on lines 152..159

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    findViewById<Button>(R.id.sell_book_button).setOnClickListener {
            startActivity(Intent(this, AddSaleActivity::class.java)) }
            Severity: Minor
            Found in app/src/main/java/com/github/polybooks/activities/UserProfileActivity.kt and 1 other location - About 1 hr to fix
            app/src/main/java/com/github/polybooks/activities/UserProfileActivity.kt on lines 43..44

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 88.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    findViewById<Button>(R.id.edit_user_interests).setOnClickListener {
            startActivity(Intent(this, EditUserInterestsActivity::class.java)) }
            Severity: Minor
            Found in app/src/main/java/com/github/polybooks/activities/UserProfileActivity.kt and 1 other location - About 1 hr to fix
            app/src/main/java/com/github/polybooks/activities/UserProfileActivity.kt on lines 36..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 88.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method getInternetPrice has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
            Open

            fun getInternetPrice(isbn : ISBN): CompletableFuture<String> {
    return CompletableFuture.supplyAsync {
        val appId = "?key=1orhhq0s3nrtl4kf93r3"
        val urlString = "https://booksrun.com/api/price/sell/$isbn$appId"
        val url = URL(urlString)
            Severity: Minor
            Found in app/src/main/java/com/github/polybooks/utils/InternetPrice.kt - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    val isbn13 = getJsonFields(jsonBookObject, ISBN_FIELD_NAMES)
            .map { parseISBN13(it) }
            .orElseThrow(cantParseException(ISBN_FIELD_NAMES[0]))!!
            Severity: Minor
            Found in app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt and 1 other location - About 55 mins to fix
            app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt on lines 111..113

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 85.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                    val ratingKey: String = if (rating.toString().endsWith(".0")) rating.toString().take(1) else rating.toString()
            Severity: Minor
            Found in app/src/main/java/com/github/polybooks/activities/SaleInformationActivity.kt and 1 other location - About 55 mins to fix
            app/src/main/java/com/github/polybooks/activities/SaleInformationActivity.kt on lines 96..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 85.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                        val ratingKey: String = if (rating.toString().endsWith(".0")) rating.toString().take(1) else rating.toString()
            Severity: Minor
            Found in app/src/main/java/com/github/polybooks/activities/SaleInformationActivity.kt and 1 other location - About 55 mins to fix
            app/src/main/java/com/github/polybooks/activities/SaleInformationActivity.kt on lines 109..109

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 85.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    val title = getJsonFields(jsonBookObject, TITLE_FIELD_NAMES)
            .map { parseTitle(it) }
            .orElseThrow(cantParseException(TITLE_FIELD_NAMES[0]))!!
            Severity: Minor
            Found in app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt and 1 other location - About 55 mins to fix
            app/src/main/java/com/github/polybooks/database/OLBookDatabase.kt on lines 114..116

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 85.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language