Sign upLogin

PoweredLocal/vrata

View on GitHub
Star

Showing 122 of 122 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private function getActions(Collection $paths)
    {
        return collect($paths)->reduce(function($carry, $route) {
            $pathElements = explode('.', $route['path']);
            $route['path'] = reset($pathElements);
Severity: Major
Found in app/Console/Commands/ParseServices.php and 1 other location - About 5 hrs to fix
app/Console/Commands/CombineDocs.php on lines 105..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 196.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private function getActions(Collection $paths)
    {
        return collect($paths)->reduce(function($carry, $route) {
            $pathElements = explode('.', $route['path']);
            $route['path'] = reset($pathElements);
Severity: Major
Found in app/Console/Commands/CombineDocs.php and 1 other location - About 5 hrs to fix
app/Console/Commands/ParseServices.php on lines 164..186

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 196.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function injectBodyParams has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function injectBodyParams(array $body, array $params, $prefix = '')
    {
        foreach ($params as $key => $value) {
            foreach ($body as $bodyParam => $bodyValue) {
                if (is_string($value) || is_numeric($value)) {
Severity: Minor
Found in app/Services/RestClient.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using undefined variables such as '$output' which will lead to PHP notices.
Open

            $output['origin%' . $key] = $value;
Severity: Minor
Found in app/Services/RestClient.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$output' which will lead to PHP notices.
Open

        return $output;
Severity: Minor
Found in app/Services/RestClient.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid variables with short names like $e. Configured minimum length is 3.
Open

    public function report(Exception $e)
Severity: Minor
Found in app/Exceptions/Handler.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $e. Configured minimum length is 3.
Open

    public function render($request, Exception $e)
Severity: Minor
Found in app/Exceptions/Handler.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function handle(Request $request, Closure $next, $id)
Severity: Minor
Found in app/Http/Middleware/HelperMiddleware.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function getRoute($id)
Severity: Minor
Found in app/Routing/RouteRegistry.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The class RestClient has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
Open

class RestClient
{
    /**
     * @var Client
     */
Severity: Minor
Found in app/Services/RestClient.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Expected 1 space after FUNCTION keyword; 0 found
Open

        return collect($paths)->reduce(function($carry, $route) {
Severity: Minor
Found in app/Console/Commands/CombineDocs.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace App\Presenters;
Severity: Minor
Found in app/Presenters/RawPresenter.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in app/Services/RestClient.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

                    collect($resource['swagger2-data'])->map(function($data, $method) {
Severity: Minor
Found in app/Console/Commands/ParseServices.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

        $output = $this->actions->reduce(function($carry, $batch) use (&$parametersJar, $client) {
Severity: Minor
Found in app/Http/Controllers/GatewayController.php by phpcodesniffer

Each PHP statement must be on a line by itself
Open

        $wrapper->setCritical($batch->filter(function($action) { return $action->isCritical(); })->count());
Severity: Minor
Found in app/Services/RestClient.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

        return $resources->reduce(function($carry, $resource) {
Severity: Minor
Found in app/Console/Commands/ParseServices.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace App\Routing;
Severity: Minor
Found in app/Routing/Route.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

        return collect(array_keys($output))->reduce(function($carry, $alias) use ($output) {
Severity: Minor
Found in app/Http/Controllers/GatewayController.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

        return collect($this->config['services'])->map(function($settings, $serviceId) {
Severity: Minor
Found in app/Console/Commands/CombineDocs.php by phpcodesniffer
Severity
Category
Status
Source
Language