Function add_menu_bubble
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Each class must be in a namespace of at least one level (a top-level vendor name) Open
class Gitium_Menu_Bubble extends Gitium_Menu {
- Exclude checks
The class Gitium_Menu_Bubble is not named in CamelCase. Open
class Gitium_Menu_Bubble extends Gitium_Menu {
public function __construct() {
parent::__construct( $this->gitium_menu_slug, $this->gitium_menu_slug );
add_action( GITIUM_ADMIN_MENU_ACTION, array( $this, 'add_menu_bubble' ) );
- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}
Source
Expected 0 spaces before closing bracket; 2 found Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
if ( ! empty( $changes ) ) :
- Exclude checks
Space found before closing bracket of FOREACH loop Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Expected 0 spaces before closing bracket; 2 found Open
if ( ! _gitium_is_status_working() ) {
- Exclude checks
Expected 0 spaces before closing bracket; 2 found Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Opening brace of a class must be on the line after the definition Open
class Gitium_Menu_Bubble extends Gitium_Menu {
- Exclude checks
Method name "Gitium_Menu_Bubble::add_menu_bubble" is not in camel caps format Open
public function add_menu_bubble() {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
if ( $this->menu_slug == $menu[ $key ][2] ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
if ( $this->menu_slug == $menu[ $key ][2] ) {
- Exclude checks
Space found after opening bracket of FOREACH loop Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Space found after opening bracket of FOREACH loop Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
if ( false === $menu_bubble ) { $menu_bubble = ''; }
- Exclude checks
Space found before closing bracket of FOREACH loop Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
parent::__construct( $this->gitium_menu_slug, $this->gitium_menu_slug );
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$menu_bubble = " <span class='update-plugins count-$bubble_count'><span class='plugin-count'>"
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ( $this->menu_slug == $menu[ $key ][2] ) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$menu[ $key ][0] .= $menu_bubble;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
set_transient( 'gitium_menu_bubble', $menu_bubble );
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function __construct() {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
return;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ( ! _gitium_is_status_working() ) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$bubble_count = count( $changes );
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
endif;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
public function add_menu_bubble() {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$menu[ $key ][0] = str_replace( $menu_bubble, '', $menu[ $key ][0] );
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
global $menu;
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ( ! empty( $changes ) ) :
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ( $this->menu_slug == $menu[ $key ][2] ) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
add_action( GITIUM_ADMIN_MENU_ACTION, array( $this, 'add_menu_bubble' ) );
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
$menu_bubble = get_transient( 'gitium_menu_bubble' );
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
delete_transient( 'gitium_menu_bubble' );
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
. $bubble_count . '</span></span>';
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
}
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
list( , $changes ) = _gitium_status();
- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
if ( false === $menu_bubble ) { $menu_bubble = ''; }
- Exclude checks
Closing brace must be on a line by itself Open
if ( false === $menu_bubble ) { $menu_bubble = ''; }
- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
set_transient( 'gitium_menu_bubble', $menu_bubble );
- Exclude checks
Class name "Gitium_Menu_Bubble" is not in camel caps format Open
class Gitium_Menu_Bubble extends Gitium_Menu {
- Exclude checks
Space after opening parenthesis of function call prohibited Open
parent::__construct( $this->gitium_menu_slug, $this->gitium_menu_slug );
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
$menu_bubble = get_transient( 'gitium_menu_bubble' );
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
parent::__construct( $this->gitium_menu_slug, $this->gitium_menu_slug );
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
add_action( GITIUM_ADMIN_MENU_ACTION, array( $this, 'add_menu_bubble' ) );
- Exclude checks
Opening brace should be on a new line Open
public function add_menu_bubble() {
- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
if ( false === $menu_bubble ) { $menu_bubble = ''; }
- Exclude checks
Space after opening parenthesis of function call prohibited Open
$bubble_count = count( $changes );
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
delete_transient( 'gitium_menu_bubble' );
- Exclude checks
Space after opening parenthesis of function call prohibited Open
set_transient( 'gitium_menu_bubble', $menu_bubble );
- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
if ( ! _gitium_is_status_working() ) {
- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
foreach ( $menu as $key => $value ) {
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
$menu[ $key ][0] = str_replace( $menu_bubble, '', $menu[ $key ][0] );
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
$bubble_count = count( $changes );
- Exclude checks
Space after opening parenthesis of function call prohibited Open
delete_transient( 'gitium_menu_bubble' );
- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
if ( ! empty( $changes ) ) :
- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
if ( $this->menu_slug == $menu[ $key ][2] ) {
- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
if ( $this->menu_slug == $menu[ $key ][2] ) {
- Exclude checks
Opening brace should be on a new line Open
public function __construct() {
- Exclude checks
Newline required after opening brace Open
if ( false === $menu_bubble ) { $menu_bubble = ''; }
- Exclude checks
Space after opening parenthesis of function call prohibited Open
$menu[ $key ][0] = str_replace( $menu_bubble, '', $menu[ $key ][0] );
- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
if ( ! empty( $changes ) ) :
- Exclude checks
Space after opening parenthesis of function call prohibited Open
add_action( GITIUM_ADMIN_MENU_ACTION, array( $this, 'add_menu_bubble' ) );
- Exclude checks
Space after opening parenthesis of function call prohibited Open
if ( ! empty( $changes ) ) :
- Exclude checks
Space after opening parenthesis of function call prohibited Open
$menu_bubble = get_transient( 'gitium_menu_bubble' );
- Exclude checks
The variable $menu_bubble is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $menu_bubble is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $menu_bubble is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $menu_bubble is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $menu_bubble is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $menu_bubble is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $bubble_count is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $bubble_count is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $menu_bubble is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $bubble_count is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The method add_menu_bubble is not named in camelCase. Open
public function add_menu_bubble() {
global $menu;
if ( ! _gitium_is_status_working() ) {
foreach ( $menu as $key => $value ) {
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}