gitium/inc/class-gitium-menu.php
The method redirect has a boolean flag argument $success, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method redirect() contains an exit expression. Open
Open
exit;- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}Source https://phpmd.org/rules/design.html#exitexpression
Avoid excessively long variable names like $gitium_disconnect_repo. Keep variable name length under 20. Open
Open
$gitium_disconnect_repo = filter_input(INPUT_POST, 'GitiumSubmitDisconnectRepository', FILTER_SANITIZE_FULL_SPECIAL_CHARS);- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}Source https://phpmd.org/rules/naming.html#longvariable
Each class must be in a namespace of at least one level (a top-level vendor name) Open
Open
class Gitium_Menu {- Exclude checks
The property $menu_slug is not named in camelCase. Open
Open
class Gitium_Menu {
public $gitium_menu_slug = 'gitium/gitium.php';
public $commits_menu_slug = 'gitium/gitium-commits.php';
public $settings_menu_slug = 'gitium/gitium-settings.php';- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $submenu_slug is not named in camelCase. Open
Open
class Gitium_Menu {
public $gitium_menu_slug = 'gitium/gitium.php';
public $commits_menu_slug = 'gitium/gitium-commits.php';
public $settings_menu_slug = 'gitium/gitium-settings.php';- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $commits_menu_slug is not named in camelCase. Open
Open
class Gitium_Menu {
public $gitium_menu_slug = 'gitium/gitium.php';
public $commits_menu_slug = 'gitium/gitium-commits.php';
public $settings_menu_slug = 'gitium/gitium-settings.php';- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $gitium_menu_slug is not named in camelCase. Open
Open
class Gitium_Menu {
public $gitium_menu_slug = 'gitium/gitium.php';
public $commits_menu_slug = 'gitium/gitium-commits.php';
public $settings_menu_slug = 'gitium/gitium-settings.php';- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The parameter $menu_slug is not named in camelCase. Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {
$message_id = substr(
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8
);
if ( $message ) {- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $menu_slug is not named in camelCase. Open
Open
public function __construct( $menu_slug, $submenu_slug ) {
global $git;
$this->git = $git;
$this->menu_slug = $menu_slug;- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $menu_slug is not named in camelCase. Open
Open
public function success_redirect( $message = '', $menu_slug = '' ) {
$this->redirect( $message, true, $menu_slug );
}- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The class Gitium_Menu is not named in CamelCase. Open
Open
class Gitium_Menu {
public $gitium_menu_slug = 'gitium/gitium.php';
public $commits_menu_slug = 'gitium/gitium-commits.php';
public $settings_menu_slug = 'gitium/gitium-settings.php';- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
The property $settings_menu_slug is not named in camelCase. Open
Open
class Gitium_Menu {
public $gitium_menu_slug = 'gitium/gitium.php';
public $commits_menu_slug = 'gitium/gitium-commits.php';
public $settings_menu_slug = 'gitium/gitium-settings.php';- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The parameter $submenu_slug is not named in camelCase. Open
Open
public function __construct( $menu_slug, $submenu_slug ) {
global $git;
$this->git = $git;
$this->menu_slug = $menu_slug;- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
Expected 0 spaces before closing bracket; 1 found Open
Open
if ( $message ) {- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
if ( ! isset( $gitium_disconnect_repo ) ) {- Exclude checks
Method name "Gitium_Menu::show_disconnect_repository_button" is not in camel caps format Open
Open
protected function show_disconnect_repository_button() {- Exclude checks
Expected 0 spaces between argument "$menu_slug" and closing bracket; 1 found Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {- Exclude checks
Method name "Gitium_Menu::success_redirect" is not in camel caps format Open
Open
public function success_redirect( $message = '', $menu_slug = '' ) {- Exclude checks
Expected 0 spaces between opening bracket and argument "$message"; 1 found Open
Open
public function success_redirect( $message = '', $menu_slug = '' ) {- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
if ( isset( $get_message ) && $get_message ) {- Exclude checks
Expected 0 spaces between opening bracket and argument "$message"; 1 found Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
if ( ! $this->git->remove_remote() ) {- Exclude checks
Method name "Gitium_Menu::disconnect_repository" is not in camel caps format Open
Open
public function disconnect_repository() {- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
if ( '' === $menu_slug ) { $menu_slug = $this->menu_slug; }- Exclude checks
Expected 0 spaces between argument "$submenu_slug" and closing bracket; 1 found Open
Open
public function __construct( $menu_slug, $submenu_slug ) {- Exclude checks
Expected 0 spaces between argument "$menu_slug" and closing bracket; 1 found Open
Open
public function success_redirect( $message = '', $menu_slug = '' ) {- Exclude checks
Method name "Gitium_Menu::show_message" is not in camel caps format Open
Open
public function show_message() {- Exclude checks
Expected 0 spaces between opening bracket and argument "$menu_slug"; 1 found Open
Open
public function __construct( $menu_slug, $submenu_slug ) {- Exclude checks
Expected 0 spaces before closing bracket; 2 found Open
Open
if ( $message ) : ?>- Exclude checks
Opening brace of a class must be on the line after the definition Open
Open
class Gitium_Menu {- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
Open
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
Open
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $menu_slug;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'message' => $message_id,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
'success' => $success,- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
wp_safe_redirect( $url );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function show_message() {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->menu_slug = $menu_slug;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
),- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ( ! isset( $gitium_disconnect_repo ) ) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
gitium_uninstall_hook();- Exclude checks
Line exceeds 120 characters; contains 121 characters Open
Open
$this->success_redirect( __('You are now disconnected from the repository. New key pair generated.', 'gitium') );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ( $message ) : ?>- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<?php endif;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url = esc_url_raw( add_query_arg(- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
?>- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $gitium_menu_slug = 'gitium/gitium.php';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
exit;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ( ! $this->git->remove_remote() ) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<?php- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<?php- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$message_id = substr(- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ( $message ) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
check_admin_referer( 'gitium-admin' );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<input type="submit" name="GitiumSubmitDisconnectRepository" value='<?php _e( 'Disconnect from repo', 'gitium' ); ?>' class="button secondary" onclick="return confirm('<?php _e( 'Are you sure you want to disconnect from the remote repository?', 'gitium' ); ?>')"/> - Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $submenu_slug;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->git = $git;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
) );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ( isset( $get_message ) && $get_message ) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $settings_menu_slug = 'gitium/gitium-settings.php';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function success_redirect( $message = '', $menu_slug = '' ) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->redirect( $message, true, $menu_slug );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
wp_nonce_field( 'gitium-admin' );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $commits_menu_slug = 'gitium/gitium-commits.php';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$message = get_transient( 'message_'. $get_message );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function __construct( $menu_slug, $submenu_slug ) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
global $git;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
set_transient( 'message_' . $message_id, $message, 900 );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
?>- Exclude checks
Line exceeds 120 characters; contains 282 characters Open
Open
<input type="submit" name="GitiumSubmitDisconnectRepository" value='<?php _e( 'Disconnect from repo', 'gitium' ); ?>' class="button secondary" onclick="return confirm('<?php _e( 'Are you sure you want to disconnect from the remote repository?', 'gitium' ); ?>')"/> - Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$url = network_admin_url( 'admin.php?page=' . $menu_slug );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
</form>- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<div class="<?php echo esc_attr( $type ); ?>"><p><?php echo esc_html( $message ); ?></p></div>- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $git = null;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->submenu_slug = $submenu_slug;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
array(- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->redirect( __('Could not remove remote.', 'gitium') );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$this->success_redirect( __('You are now disconnected from the repository. New key pair generated.', 'gitium') );- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$get_success = filter_input(INPUT_GET, 'success', FILTER_SANITIZE_FULL_SPECIAL_CHARS);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
protected function show_disconnect_repository_button() {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$get_message = filter_input(INPUT_GET, 'message', FILTER_SANITIZE_FULL_SPECIAL_CHARS);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
if ( '' === $menu_slug ) { $menu_slug = $this->menu_slug; }- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function disconnect_repository() {- Exclude checks
Line exceeds 120 characters; contains 131 characters Open
Open
$gitium_disconnect_repo = filter_input(INPUT_POST, 'GitiumSubmitDisconnectRepository', FILTER_SANITIZE_FULL_SPECIAL_CHARS);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
<form name="gitium_form_disconnect" id="gitium_form_disconnect" action="" method="POST">- Exclude checks
Class name "Gitium_Menu" is not in camel caps format Open
Open
class Gitium_Menu {- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
set_transient( 'message_' . $message_id, $message, 900 );- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
Open
if ( '' === $menu_slug ) { $menu_slug = $this->menu_slug; }- Exclude checks
Closing brace must be on a line by itself Open
Open
if ( '' === $menu_slug ) { $menu_slug = $this->menu_slug; }- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
Open
if ( ! $this->git->remove_remote() ) {- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
$this->redirect( __('Could not remove remote.', 'gitium') );- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
Open
if ( $message ) : ?>- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
<input type="submit" name="GitiumSubmitDisconnectRepository" value='<?php _e( 'Disconnect from repo', 'gitium' ); ?>' class="button secondary" onclick="return confirm('<?php _e( 'Are you sure you want to disconnect from the remote repository?', 'gitium' ); ?>')"/> - Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
Open
if ( $message ) {- Exclude checks
Opening brace should be on a new line Open
Open
public function disconnect_repository() {- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
<div class="<?php echo esc_attr( $type ); ?>"><p><?php echo esc_html( $message ); ?></p></div>- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
$url = esc_url_raw( add_query_arg(- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
Open
if ( ! isset( $gitium_disconnect_repo ) ) {- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
<div class="<?php echo esc_attr( $type ); ?>"><p><?php echo esc_html( $message ); ?></p></div>- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
<input type="submit" name="GitiumSubmitDisconnectRepository" value='<?php _e( 'Disconnect from repo', 'gitium' ); ?>' class="button secondary" onclick="return confirm('<?php _e( 'Are you sure you want to disconnect from the remote repository?', 'gitium' ); ?>')"/> - Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
<input type="submit" name="GitiumSubmitDisconnectRepository" value='<?php _e( 'Disconnect from repo', 'gitium' ); ?>' class="button secondary" onclick="return confirm('<?php _e( 'Are you sure you want to disconnect from the remote repository?', 'gitium' ); ?>')"/> - Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
<input type="submit" name="GitiumSubmitDisconnectRepository" value='<?php _e( 'Disconnect from repo', 'gitium' ); ?>' class="button secondary" onclick="return confirm('<?php _e( 'Are you sure you want to disconnect from the remote repository?', 'gitium' ); ?>')"/> - Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
$url = network_admin_url( 'admin.php?page=' . $menu_slug );- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
$this->redirect( $message, true, $menu_slug );- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
$this->redirect( $message, true, $menu_slug );- Exclude checks
Line indented incorrectly; expected 12 spaces, found 10 Open
Open
?>- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
$this->success_redirect( __('You are now disconnected from the repository. New key pair generated.', 'gitium') );- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
<div class="<?php echo esc_attr( $type ); ?>"><p><?php echo esc_html( $message ); ?></p></div>- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
set_transient( 'message_' . $message_id, $message, 900 );- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
check_admin_referer( 'gitium-admin' );- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
wp_safe_redirect( $url );- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
if ( isset( $get_message ) && $get_message ) {- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
wp_nonce_field( 'gitium-admin' );- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
$this->redirect( __('Could not remove remote.', 'gitium') );- Exclude checks
Opening brace should be on a new line Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {- Exclude checks
Newline required after opening brace Open
Open
if ( '' === $menu_slug ) { $menu_slug = $this->menu_slug; }- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
$url = network_admin_url( 'admin.php?page=' . $menu_slug );- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
$url = esc_url_raw( add_query_arg(- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
wp_safe_redirect( $url );- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
check_admin_referer( 'gitium-admin' );- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
if ( isset( $get_message ) && $get_message ) {- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
$message = get_transient( 'message_'. $get_message );- Exclude checks
Opening brace should be on a new line Open
Open
protected function show_disconnect_repository_button() {- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
wp_nonce_field( 'gitium-admin' );- Exclude checks
Opening brace should be on a new line Open
Open
public function success_redirect( $message = '', $menu_slug = '' ) {- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
if ( ! isset( $gitium_disconnect_repo ) ) {- Exclude checks
Opening brace should be on a new line Open
Open
public function show_message() {- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
<div class="<?php echo esc_attr( $type ); ?>"><p><?php echo esc_html( $message ); ?></p></div>- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
$this->success_redirect( __('You are now disconnected from the repository. New key pair generated.', 'gitium') );- Exclude checks
Expected 0 spaces after opening bracket; 1 found Open
Open
if ( isset( $get_message ) && $get_message ) {- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
$message = get_transient( 'message_'. $get_message );- Exclude checks
Expected 0 spaces before closing bracket; 1 found Open
Open
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
if ( ! isset( $gitium_disconnect_repo ) ) {- Exclude checks
Space after opening parenthesis of function call prohibited Open
Open
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Exclude checks
Opening brace should be on a new line Open
Open
public function __construct( $menu_slug, $submenu_slug ) {- Exclude checks
The variable $message_id is not named in camelCase. Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {
$message_id = substr(
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8
);
if ( $message ) {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $get_success is not named in camelCase. Open
Open
public function show_message() {
$get_message = filter_input(INPUT_GET, 'message', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
$get_success = filter_input(INPUT_GET, 'success', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( isset( $get_message ) && $get_message ) {
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $menu_slug is not named in camelCase. Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {
$message_id = substr(
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8
);
if ( $message ) {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $get_message is not named in camelCase. Open
Open
public function show_message() {
$get_message = filter_input(INPUT_GET, 'message', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
$get_success = filter_input(INPUT_GET, 'success', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( isset( $get_message ) && $get_message ) {
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $get_success is not named in camelCase. Open
Open
public function show_message() {
$get_message = filter_input(INPUT_GET, 'message', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
$get_success = filter_input(INPUT_GET, 'success', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( isset( $get_message ) && $get_message ) {
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $get_message is not named in camelCase. Open
Open
public function show_message() {
$get_message = filter_input(INPUT_GET, 'message', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
$get_success = filter_input(INPUT_GET, 'success', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( isset( $get_message ) && $get_message ) {
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $get_success is not named in camelCase. Open
Open
public function show_message() {
$get_message = filter_input(INPUT_GET, 'message', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
$get_success = filter_input(INPUT_GET, 'success', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( isset( $get_message ) && $get_message ) {
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $menu_slug is not named in camelCase. Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {
$message_id = substr(
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8
);
if ( $message ) {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $get_message is not named in camelCase. Open
Open
public function show_message() {
$get_message = filter_input(INPUT_GET, 'message', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
$get_success = filter_input(INPUT_GET, 'success', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( isset( $get_message ) && $get_message ) {
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $submenu_slug is not named in camelCase. Open
Open
public function __construct( $menu_slug, $submenu_slug ) {
global $git;
$this->git = $git;
$this->menu_slug = $menu_slug;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $get_message is not named in camelCase. Open
Open
public function show_message() {
$get_message = filter_input(INPUT_GET, 'message', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
$get_success = filter_input(INPUT_GET, 'success', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( isset( $get_message ) && $get_message ) {
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $message_id is not named in camelCase. Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {
$message_id = substr(
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8
);
if ( $message ) {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $menu_slug is not named in camelCase. Open
Open
public function __construct( $menu_slug, $submenu_slug ) {
global $git;
$this->git = $git;
$this->menu_slug = $menu_slug;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $message_id is not named in camelCase. Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {
$message_id = substr(
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8
);
if ( $message ) {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gitium_disconnect_repo is not named in camelCase. Open
Open
public function disconnect_repository() {
$gitium_disconnect_repo = filter_input(INPUT_POST, 'GitiumSubmitDisconnectRepository', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( ! isset( $gitium_disconnect_repo ) ) {
return;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $gitium_disconnect_repo is not named in camelCase. Open
Open
public function disconnect_repository() {
$gitium_disconnect_repo = filter_input(INPUT_POST, 'GitiumSubmitDisconnectRepository', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( ! isset( $gitium_disconnect_repo ) ) {
return;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $menu_slug is not named in camelCase. Open
Open
public function redirect( $message = '', $success = false, $menu_slug = '' ) {
$message_id = substr(
md5( str_shuffle( 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' ) . time() ), 0, 8
);
if ( $message ) {- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $menu_slug is not named in camelCase. Open
Open
public function success_redirect( $message = '', $menu_slug = '' ) {
$this->redirect( $message, true, $menu_slug );
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The method success_redirect is not named in camelCase. Open
Open
public function success_redirect( $message = '', $menu_slug = '' ) {
$this->redirect( $message, true, $menu_slug );
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method disconnect_repository is not named in camelCase. Open
Open
public function disconnect_repository() {
$gitium_disconnect_repo = filter_input(INPUT_POST, 'GitiumSubmitDisconnectRepository', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( ! isset( $gitium_disconnect_repo ) ) {
return;- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method show_message is not named in camelCase. Open
Open
public function show_message() {
$get_message = filter_input(INPUT_GET, 'message', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
$get_success = filter_input(INPUT_GET, 'success', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
if ( isset( $get_message ) && $get_message ) {
$type = ( isset( $get_success ) && $get_success == 1 ) ? 'updated' : 'error';- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method show_disconnect_repository_button is not named in camelCase. Open
Open
protected function show_disconnect_repository_button() {
?>
<form name="gitium_form_disconnect" id="gitium_form_disconnect" action="" method="POST">
<?php
wp_nonce_field( 'gitium-admin' );- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}