Sign upLogin

Princeton-CDH/ppa-django

View on GitHub
Star
ppa/archive/forms.py

Summary

Maintainability
C
1 day
Test Coverage

File forms.py has 394 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from django import forms
from django.core.cache import cache
from django.core.exceptions import ValidationError
from django.core.validators import RegexValidator
from django.db.models import Max, Min
Severity: Minor
Found in ppa/archive/forms.py - About 5 hrs to fix

Function set_choices_from_facets has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def set_choices_from_facets(self, facets):
        """Set choices on field from a dictionary of facets"""

        # update collections multiselect based on facets
Severity: Minor
Found in ppa/archive/forms.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create_option has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def create_option(
Severity: Major
Found in ppa/archive/forms.py - About 50 mins to fix

Function create_option has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def create_option(
Severity: Major
Found in ppa/archive/forms.py - About 50 mins to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    title = forms.CharField(
        label="Title",
        required=False,
        widget=forms.TextInput(
            attrs={
Severity: Major
Found in ppa/archive/forms.py and 3 other locations - About 45 mins to fix
ppa/archive/forms.py on lines 211..218
ppa/archive/forms.py on lines 233..240
ppa/archive/forms.py on lines 481..488

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    query = forms.CharField(
        label="Keyword or Phrase",
        required=False,
        widget=forms.TextInput(
            attrs={
Severity: Major
Found in ppa/archive/forms.py and 3 other locations - About 45 mins to fix
ppa/archive/forms.py on lines 222..229
ppa/archive/forms.py on lines 233..240
ppa/archive/forms.py on lines 481..488

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    author = forms.CharField(
        label="Author",
        required=False,
        widget=forms.TextInput(
            attrs={
Severity: Major
Found in ppa/archive/forms.py and 3 other locations - About 45 mins to fix
ppa/archive/forms.py on lines 211..218
ppa/archive/forms.py on lines 222..229
ppa/archive/forms.py on lines 481..488

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    query = forms.CharField(
        label="Search within the Volume",
        required=False,
        widget=forms.TextInput(
            attrs={
Severity: Major
Found in ppa/archive/forms.py and 3 other locations - About 45 mins to fix
ppa/archive/forms.py on lines 211..218
ppa/archive/forms.py on lines 222..229
ppa/archive/forms.py on lines 233..240

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status