Sign upLogin

ProjectCacophony/Gateway

View on GitHub
Star

Showing 22 of 23 total issues

Method EventHandler.OnDiscordEvent has 181 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (eh *EventHandler) OnDiscordEvent(session *discordgo.Session, eventItem interface{}) {
    var err error

    if session == nil || session.State == nil || session.State.User == nil {
        return
Severity: Major
Found in pkg/handler/handler.go - About 6 hrs to fix

    Method EventHandler.OnDiscordEvent has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
    Open

    func (eh *EventHandler) OnDiscordEvent(session *discordgo.Session, eventItem interface{}) {
    var err error

    if session == nil || session.State == nil || session.State.User == nil {
        return
    Severity: Minor
    Found in pkg/handler/handler.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func memberDiff(old, new *discordgo.Member) (*events.Event, error) {
    if old == nil || new == nil {
        return nil, nil
    }
    Severity: Major
    Found in pkg/handler/diff.go and 1 other location - About 1 hr to fix
    pkg/handler/diff.go on lines 8..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func guildDiff(old, new *discordgo.Guild) (*events.Event, error) {
    if old == nil || new == nil {
        return nil, nil
    }
    Severity: Major
    Found in pkg/handler/diff.go and 1 other location - About 1 hr to fix
    pkg/handler/diff.go on lines 26..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method EventHandler.OnDiscordEvent has 9 return statements (exceeds 4 allowed).
    Open

    func (eh *EventHandler) OnDiscordEvent(session *discordgo.Session, eventItem interface{}) {
    var err error

    if session == nil || session.State == nil || session.State.User == nil {
        return
    Severity: Major
    Found in pkg/handler/handler.go - About 55 mins to fix

      Function NewEventHandler has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          logger *zap.Logger,
    redisClient *redis.Client,
    publisher *events.Publisher,
    checker *whitelist.Checker,
    state *state.State,
      Severity: Major
      Found in pkg/handler/handler.go - About 50 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func webhooksDiff(guildID string, old, new []*discordgo.Webhook) (*events.Event, error) {
    event, err := events.New(events.CacophonyDiffWebhooks)
    if err != nil {
        return nil, err
    }
        Severity: Minor
        Found in pkg/handler/diff.go and 1 other location - About 50 mins to fix
        pkg/handler/diff.go on lines 80..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func emojiDiff(guildID string, old, new []*discordgo.Emoji) (*events.Event, error) {
    event, err := events.New(events.CacophonyDiffEmoji)
    if err != nil {
        return nil, err
    }
        Severity: Minor
        Found in pkg/handler/diff.go and 1 other location - About 50 mins to fix
        pkg/handler/diff.go on lines 94..106

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (c *Checker) IsWhitelisted(guildID string) bool {
    if !c.enable {
        return true
    }
        Severity: Minor
        Found in pkg/whitelist/checker.go and 1 other location - About 35 mins to fix
        pkg/whitelist/checker.go on lines 109..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (c *Checker) IsBlacklisted(guildID string) bool {
    if !c.enable {
        return false
    }
        Severity: Minor
        Found in pkg/whitelist/checker.go and 1 other location - About 35 mins to fix
        pkg/whitelist/checker.go on lines 93..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if err != nil && err != redis.Nil {
                raven.CaptureError(err, nil)
                c.logger.Error("failed to retrieve blacklist", zap.Error(err))
            } else {
                c.blacklistLock.Lock()
        Severity: Minor
        Found in pkg/whitelist/checker.go and 1 other location - About 35 mins to fix
        pkg/whitelist/checker.go on lines 65..73

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if err != nil && err != redis.Nil {
                raven.CaptureError(err, nil)
                c.logger.Error("failed to retrieve whitelist", zap.Error(err))
            } else {
                c.whitelistLock.Lock()
        Severity: Minor
        Found in pkg/whitelist/checker.go and 1 other location - About 35 mins to fix
        pkg/whitelist/checker.go on lines 76..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        exported function NewSession should have comment or be unexported
        Open

        func NewSession(
        Severity: Minor
        Found in cmd/gateway/session.go by golint

        exported method EventHandler.IsDuplicate should have comment or be unexported
        Open

        func (eh *EventHandler) IsDuplicate(key string, expiration time.Duration) (bool, error) {
        Severity: Minor
        Found in pkg/handler/deduplicate.go by golint

        exported method Checker.GetWhitelist should have comment or be unexported
        Open

        func (c *Checker) GetWhitelist() []string {
        Severity: Minor
        Found in pkg/whitelist/checker.go by golint

        exported type Checker should have comment or be unexported
        Open

        type Checker struct {
        Severity: Minor
        Found in pkg/whitelist/checker.go by golint

        exported method Checker.GetBlacklist should have comment or be unexported
        Open

        func (c *Checker) GetBlacklist() []string {
        Severity: Minor
        Found in pkg/whitelist/checker.go by golint

        exported function NewChecker should have comment or be unexported
        Open

        func NewChecker(
        Severity: Minor
        Found in pkg/whitelist/checker.go by golint

        exported method Checker.IsWhitelisted should have comment or be unexported
        Open

        func (c *Checker) IsWhitelisted(guildID string) bool {
        Severity: Minor
        Found in pkg/whitelist/checker.go by golint

        2: cannot find package "gitlab.com/Cacophony/go-kit/errortracking" in any of:
        Open

            "gitlab.com/Cacophony/go-kit/errortracking"
        Severity: Minor
        Found in cmd/gateway/config.go by govet
        Severity
        Category
        Status
        Source
        Language