Sign upLogin

Promact/slack-erp-custom-integration-mvc

View on GitHub
Star
Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        [Fact, Trait("Category", "Required")]
        public async Task UpdateLeaveFalseAsync()
        {
            await _leaveRequestRepository.ApplyLeaveAsync(leave);
            var leaves = await _leaveRequestRepository.LeaveByIdAsync(1);
Severity: Major
Found in Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs and 1 other location - About 1 hr to fix
Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs on lines 114..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        [Fact, Trait("Category", "Required")]
        public async Task UpdateLeaveAsync()
        {
            await _leaveRequestRepository.ApplyLeaveAsync(leave);
            var leaves = await _leaveRequestRepository.LeaveByIdAsync(1);
Severity: Major
Found in Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs and 1 other location - About 1 hr to fix
Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs on lines 199..207

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        [Fact, Trait("Category", "Required")]
        public async void LeaveListStatusByUserId()
        {
            await _leaveRequestRepository.ApplyLeaveAsync(leave);
            var leaves = _leaveRequestRepository.LeaveListStatusByUserId(_stringConstant.StringIdForTest);
Severity: Minor
Found in Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs and 1 other location - About 50 mins to fix
Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs on lines 177..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        [Fact, Trait("Category", "Required")]
        public async void LeaveListStatusByUserIdFalse()
        {
            await _leaveRequestRepository.ApplyLeaveAsync(leave);
            var leaves = _leaveRequestRepository.LeaveListStatusByUserId(_stringConstant.StringIdForTest);
Severity: Minor
Found in Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs and 1 other location - About 50 mins to fix
Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs on lines 92..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        [Fact, Trait("Category", "Required")]
        public async Task LeaveByIdAsync()
        {
            await _leaveRequestRepository.ApplyLeaveAsync(leave);
            var leaves = await _leaveRequestRepository.LeaveByIdAsync(1);
Severity: Major
Found in Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs and 2 other locations - About 50 mins to fix
Slack.Automation/Promact.Core.Test/BotQuestionRepositoryTest.cs on lines 46..52
Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs on lines 188..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        [Fact, Trait("Category", "Required")]
        public async Task LeaveByIdFalseAsync()
        {
            await _leaveRequestRepository.ApplyLeaveAsync(leave);
            var leaves = await _leaveRequestRepository.LeaveByIdAsync(1);
Severity: Major
Found in Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs and 2 other locations - About 50 mins to fix
Slack.Automation/Promact.Core.Test/BotQuestionRepositoryTest.cs on lines 46..52
Slack.Automation/Promact.Core.Test/LeaveRequestRepositoryTest.cs on lines 103..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status