Sign upLogin

Promact/slack-erp-custom-integration-mvc

View on GitHub
Star
Slack.Automation/Promact.Erp.Util/HttpClient/HttpClientService.cs

Summary

Maintainability
C
1 day
Test Coverage

Method GetAsync has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public async Task<string> GetAsync(string baseUrl, string contentUrl, string accessToken, string accessTokenType)
        {
            try
            {
                _client = new System.Net.Http.HttpClient();
Severity: Minor
Found in Slack.Automation/Promact.Erp.Util/HttpClient/HttpClientService.cs - About 1 hr to fix

    Method PostAsync has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            public async Task<string> PostAsync(string baseUrl, string contentString, string contentHeader, string accessToken, string accessTokenType)
    Severity: Minor
    Found in Slack.Automation/Promact.Erp.Util/HttpClient/HttpClientService.cs - About 35 mins to fix

      Method PutAsync has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              public async Task<string> PutAsync(string baseUrl, string contentString, string contentHeader, string accessToken, string accessTokenType)
      Severity: Minor
      Found in Slack.Automation/Promact.Erp.Util/HttpClient/HttpClientService.cs - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                public async Task<string> PostAsync(string baseUrl, string contentString, string contentHeader, string accessToken, string accessTokenType)
        {
            try
            {
                _client = new System.Net.Http.HttpClient();
        Severity: Major
        Found in Slack.Automation/Promact.Erp.Util/HttpClient/HttpClientService.cs and 1 other location - About 3 hrs to fix
        Slack.Automation/Promact.Erp.Util/HttpClient/HttpClientService.cs on lines 111..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 223.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                public async Task<string> PutAsync(string baseUrl, string contentString, string contentHeader, string accessToken, string accessTokenType)
        {
            try
            {
                _client = new System.Net.Http.HttpClient();
        Severity: Major
        Found in Slack.Automation/Promact.Erp.Util/HttpClient/HttpClientService.cs and 1 other location - About 3 hrs to fix
        Slack.Automation/Promact.Erp.Util/HttpClient/HttpClientService.cs on lines 77..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 223.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status