Sign upLogin

Qqwy/ruby-prop_check

View on GitHub
Star
lib/prop_check/generators.rb

Summary

Maintainability
C
1 day
Test Coverage
A
93%

File generators.rb has 375 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'date'
require 'prop_check/generator'
require 'prop_check/lazy_tree'
module PropCheck
  ##
Severity: Minor
Found in lib/prop_check/generators.rb - About 5 hrs to fix

    Method make_array_uniq has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        private def make_array_uniq(element_generator, min, amount, uniq_fun)
      Generator.new do |**kwargs|
        arr = []
        uniques = Set.new
        count = 0
    Severity: Minor
    Found in lib/prop_check/generators.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method make_array_uniq has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private def make_array_uniq(element_generator, min, amount, uniq_fun)
      Generator.new do |**kwargs|
        arr = []
        uniques = Set.new
        count = 0
    Severity: Minor
    Found in lib/prop_check/generators.rb - About 1 hr to fix

      Method make_array has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private def make_array(element_generator, min, count, uniq)
      amount = min if count < min
      amount = min if count == min && min != 0
      amount ||= (count - min)
      Severity: Minor
      Found in lib/prop_check/generators.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method random_pseudofactors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private def random_pseudofactors(size, rng)
      return [size].to_enum if size < 2

      Enumerator.new do |yielder|
        loop do
      Severity: Minor
      Found in lib/prop_check/generators.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private def datetime_from_offset(offset_gen, epoch:)
      if epoch
        offset_gen.map { |offset| DateTime.jd(epoch.ajd + offset) }
      else
        offset_gen.with_config.map do |offset, config|
      Severity: Minor
      Found in lib/prop_check/generators.rb and 1 other location - About 30 mins to fix
      lib/prop_check/generators.rb on lines 756..762

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private def date_from_offset(offset_gen, epoch:)
      if epoch
        offset_gen.map { |offset| Date.jd(epoch.jd + offset) }
      else
        offset_gen.with_config.map do |offset, config|
      Severity: Minor
      Found in lib/prop_check/generators.rb and 1 other location - About 30 mins to fix
      lib/prop_check/generators.rb on lines 826..832

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status