Sign upLogin

QualiSystems/vCenterShell

View on GitHub
Star
package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py

Summary

Maintainability
D
3 days
Test Coverage

VCenterAutoModelDiscovery has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

class VCenterAutoModelDiscovery(object):
    def __init__(self):
        self.dc = None
        self.parser = ResourceModelParser()
        self.pv_service = pyVmomiService(SmartConnect, Disconnect, SynchronousTaskWaiter())
Severity: Minor
Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 3 hrs to fix

    File model_auto_discovery.py has 297 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import collections

from pyVim.connect import SmartConnect, Disconnect
from pyVmomi import vim
    Severity: Minor
    Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 3 hrs to fix

      Function _find_resource_pool has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def _find_resource_pool(self, name, root):
        if hasattr(root, 'resourcePool'):
            resource_pool = root.resourcePool
            if hasattr(resource_pool, 'name') and resource_pool.name == name:
                return resource_pool
      Severity: Minor
      Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _validate_saved_sandbox_storage has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def _validate_saved_sandbox_storage(self, si, all_items_in_vc, auto_att, dc_name, attributes, key):
      Severity: Minor
      Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

        Function _get_default_from_vc_by_type_and_name has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def _get_default_from_vc_by_type_and_name(items_in_vc, vim_type, name=None):
        items = []
        if not isinstance(vim_type, collections.Iterable):
            vim_type = [vim_type]
        for item in items_in_vc:
        Severity: Minor
        Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _validate_holding_network has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def _validate_holding_network(self, si, all_items_in_vc, auto_att, dc_name, attributes, key):
        Severity: Minor
        Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

          Function _validate_vm_location has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def _validate_vm_location(self, si, all_items_in_vc, auto_att, dc_name, attributes, key):
          Severity: Minor
          Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

            Function _validate_vm_resource_pool has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def _validate_vm_resource_pool(self, si, all_items_in_vc, auto_att, dc_name, attributes, key):
            Severity: Minor
            Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

              Function _validate_attribute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def _validate_attribute(self, si, attributes, vim_type, name, prefix=''):
        if name in attributes and attributes[name]:
            att_value = self._get_attribute_value(attributes, name, prefix)

            obj = self.pv_service.get_folder(si, att_value)
              Severity: Minor
              Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _validate_default_dvswitch has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def _validate_default_dvswitch(self, si, all_items_in_vc, auto_att, dc_name, attributes, key):
              Severity: Minor
              Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

                Function _validate_vm_storage has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def _validate_vm_storage(self, si, all_items_in_vc, auto_att, dc_name, attributes, key):
                Severity: Minor
                Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

                  Function _validate_vm_cluster has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def _validate_vm_cluster(self, si, all_items_in_vc, auto_att, dc_name, attributes, key):
                  Severity: Minor
                  Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

                    Function _validate_shutdown_method has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def _validate_shutdown_method(self, si, all_items_in_vc, auto_att, dc_name, attributes, key):
                    Severity: Minor
                    Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 45 mins to fix

                      Function _validate_attribute has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def _validate_attribute(self, si, attributes, vim_type, name, prefix=''):
                      Severity: Minor
                      Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 35 mins to fix

                        Function _validate_empty has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def _validate_empty(si, all_items_in_vc, attributes, auto_attr, dc_name, key):
                        Severity: Minor
                        Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py - About 35 mins to fix

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                                  if not datastore:
            datastore = self._get_default(all_items_in_vc, accepted_types, key)
            d_name = self.get_full_name(dc_name, datastore)
            # removing the upper folder
            d_name = d_name.replace('datastore/', '')
                          Severity: Major
                          Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py and 2 other locations - About 2 hrs to fix
                          package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py on lines 199..205
                          package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py on lines 248..254

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                                  if not cluster:
            cluster = self._get_default(all_items_in_vc, accepted_types, key)
            c_name = self.get_full_name(dc_name, cluster)
            # removing the upper folder
            c_name = c_name.replace('host/', '')
                          Severity: Major
                          Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py and 2 other locations - About 2 hrs to fix
                          package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py on lines 199..205
                          package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py on lines 216..222

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                                  if not datastore:
            datastore = self._get_default(all_items_in_vc, accepted_types, key)
            d_name = self.get_full_name(dc_name, datastore)
            # removing the upper folder
            d_name = d_name.replace('datastore/', '')
                          Severity: Major
                          Found in package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py and 2 other locations - About 2 hrs to fix
                          package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py on lines 216..222
                          package/cloudshell/cp/vcenter/common/vcenter/model_auto_discovery.py on lines 248..254

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 57.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status