Sign upLogin

QualiSystems/vCenterShell

View on GitHub
Star
package/cloudshell/cp/vcenter/models/QualiDriverModels.py

Summary

Maintainability
C
1 day
Test Coverage

Function __init__ has 11 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, id, name, fullname, type, address, model, family, description, attributes, appdata_json,
Severity: Major
Found in package/cloudshell/cp/vcenter/models/QualiDriverModels.py - About 1 hr to fix

    Function __init__ has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, source, target, target_family, target_model, target_type, target_attributes, direction, alias,
    Severity: Major
    Found in package/cloudshell/cp/vcenter/models/QualiDriverModels.py - About 1 hr to fix

      Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, environment_name, environment_path, domain, description, owner_user, owner_email,
      Severity: Major
      Found in package/cloudshell/cp/vcenter/models/QualiDriverModels.py - About 50 mins to fix

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, connectivity, resource, remote_reservation, ports, remote_endpoints):
        Severity: Minor
        Found in package/cloudshell/cp/vcenter/models/QualiDriverModels.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class ResourceCommandContext:
    def __init__(self, connectivity, resource, reservation, connectors):
        self.connectivity = connectivity  # Connectivity details that can help connect to the APIs
        """:type : ConnectivityContext"""
        self.resource = resource  # The details of the resource using the driver
          Severity: Major
          Found in package/cloudshell/cp/vcenter/models/QualiDriverModels.py and 1 other location - About 2 hrs to fix
          package/cloudshell/cp/vcenter/models/QualiDriverModels.py on lines 21..30

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          class ConnectivityContext:
    def __init__(self, server_address, cloudshell_api_port, quali_api_port, admin_auth_token):
        self.server_address = server_address  # The address of the Quali server
        """:type : str"""
        self.cloudshell_api_port = cloudshell_api_port  # the port of the TestShell API
          Severity: Major
          Found in package/cloudshell/cp/vcenter/models/QualiDriverModels.py and 1 other location - About 2 hrs to fix
          package/cloudshell/cp/vcenter/models/QualiDriverModels.py on lines 9..18

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status