Sign upLogin

QualiSystems/vCenterShell

View on GitHub
Star
package/cloudshell/cp/vcenter/network/dvswitch/creator.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function get_or_create_network has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def get_or_create_network(self,
Severity: Major
Found in package/cloudshell/cp/vcenter/network/dvswitch/creator.py - About 1 hr to fix

    Function _create_dv_port_group has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _create_dv_port_group(self, dv_port_name, dv_switch_name, dv_switch_path, si, spec, vlan_id,
    Severity: Major
    Found in package/cloudshell/cp/vcenter/network/dvswitch/creator.py - About 1 hr to fix

      Function dv_port_group_create_task has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def dv_port_group_create_task(dv_port_name, dv_switch, spec, vlan_id, logger, promiscuous_mode, num_ports=32):
      Severity: Minor
      Found in package/cloudshell/cp/vcenter/network/dvswitch/creator.py - About 45 mins to fix

        Function get_or_create_network has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def get_or_create_network(self,
                              si,
                              vm,
                              dv_port_name,
                              dv_switch_name,
        Severity: Minor
        Found in package/cloudshell/cp/vcenter/network/dvswitch/creator.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status