Sign upLogin

QualiSystems/vCenterShell

View on GitHub
Star
package/cloudshell/cp/vcenter/vm/deploy.py

Summary

Maintainability
C
1 day
Test Coverage

Function _deploy_a_clone has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _deploy_a_clone(self, si, logger, app_name, template_name, other_params, vcenter_data_model, reservation_id,
Severity: Major
Found in package/cloudshell/cp/vcenter/vm/deploy.py - About 1 hr to fix

    Function deploy_from_image has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def deploy_from_image(self, si, logger, session, vcenter_data_model, data_holder, resource_context, reservation_id,
                          cancellation_context):
        vm_name = self.name_generator(data_holder.app_name, reservation_id)

        connection_details = ResourceConnectionDetailsRetriever.get_connection_details(session=session,
    Severity: Minor
    Found in package/cloudshell/cp/vcenter/vm/deploy.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function deploy_from_image has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def deploy_from_image(self, si, logger, session, vcenter_data_model, data_holder, resource_context, reservation_id,
    Severity: Major
    Found in package/cloudshell/cp/vcenter/vm/deploy.py - About 1 hr to fix

      Function deploy_clone_from_vm has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def deploy_clone_from_vm(self, si, logger, data_holder, vcenter_data_model, reservation_id, cancellation_context):
      Severity: Minor
      Found in package/cloudshell/cp/vcenter/vm/deploy.py - About 45 mins to fix

        Function deploy_from_linked_clone has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def deploy_from_linked_clone(self, si, logger, data_holder, vcenter_data_model, reservation_id,
        Severity: Minor
        Found in package/cloudshell/cp/vcenter/vm/deploy.py - About 45 mins to fix

          Function deploy_from_template has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def deploy_from_template(self, si, logger, data_holder, vcenter_data_model, reservation_id, cancellation_context):
          Severity: Minor
          Found in package/cloudshell/cp/vcenter/vm/deploy.py - About 45 mins to fix

            Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __init__(self, pv_service, name_generator, ovf_service, resource_model_parser, vm_details_provider):
            Severity: Minor
            Found in package/cloudshell/cp/vcenter/vm/deploy.py - About 35 mins to fix

              Function _safely_get_vm_details has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def _safely_get_vm_details(self, vm, vm_name, vcenter_model, deploy_model, logger):
              Severity: Minor
              Found in package/cloudshell/cp/vcenter/vm/deploy.py - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def __init__(self, pv_service, name_generator, ovf_service, resource_model_parser, vm_details_provider):
        """

        :param pv_service:
        :type pv_service: cloudshell.cp.vcenter.common.vcenter.vmomi_service.pyVmomiService
                Severity: Major
                Found in package/cloudshell/cp/vcenter/vm/deploy.py and 1 other location - About 1 hr to fix
                package/cloudshell/cp/vcenter/commands/connect_dvswitch.py on lines 6..23

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def deploy_from_template(self, si, logger, data_holder, vcenter_data_model, reservation_id, cancellation_context):
        """
        :param cancellation_context:
        :param reservation_id:
        :param si:
                Severity: Major
                Found in package/cloudshell/cp/vcenter/vm/deploy.py and 1 other location - About 1 hr to fix
                package/cloudshell/cp/vcenter/vm/deploy.py on lines 65..86

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def deploy_clone_from_vm(self, si, logger, data_holder, vcenter_data_model, reservation_id, cancellation_context):
        """
        deploy Cloned VM From VM Command, will deploy vm from another vm

        :param cancellation_context:
                Severity: Major
                Found in package/cloudshell/cp/vcenter/vm/deploy.py and 1 other location - About 1 hr to fix
                package/cloudshell/cp/vcenter/vm/deploy.py on lines 88..107

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if isinstance(self.model, vCenterCloneVMFromVMResourceModel):
            data.append(VmDetailsProperty(key='Cloned VM Name', value=self.model.vcenter_vm))
                Severity: Minor
                Found in package/cloudshell/cp/vcenter/vm/deploy.py and 1 other location - About 35 mins to fix
                package/cloudshell/cp/vcenter/vm/deploy.py on lines 258..259

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if isinstance(self.model, vCenterVMFromTemplateResourceModel):
            data.append(VmDetailsProperty(key='Template Name', value=self.model.vcenter_template))
                Severity: Minor
                Found in package/cloudshell/cp/vcenter/vm/deploy.py and 1 other location - About 35 mins to fix
                package/cloudshell/cp/vcenter/vm/deploy.py on lines 247..248

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status