Sign upLogin

QualiSystems/vCenterShell

View on GitHub
Star
package/cloudshell/cp/vcenter/vm/ip_manager.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function get_ip has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def get_ip(self, vm, default_network, match_function, cancellation_context, timeout, logger):
        self._validate_vmware_tools_installed(logger, vm)
        ip = None
        reason = IpReason.Success
        if not timeout:
Severity: Minor
Found in package/cloudshell/cp/vcenter/vm/ip_manager.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _get_ip_addresses has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def _get_ip_addresses(vm, default_network):
        ips = []
        if vm.guest.ipAddress:
            ips.append(vm.guest.ipAddress)
        for nic in vm.guest.net:
Severity: Minor
Found in package/cloudshell/cp/vcenter/vm/ip_manager.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_ip has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def get_ip(self, vm, default_network, match_function, cancellation_context, timeout, logger):
Severity: Minor
Found in package/cloudshell/cp/vcenter/vm/ip_manager.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status