Sign upLogin

QutBioacoustics/baw-server

View on GitHub
Star
lib/gems/baw-workers/lib/baw_workers/mail/mailer.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method set_view_model has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def set_view_model(job, error)
        job_class = job&.dig(:job_class)
        job_args = job&.dig(:job_args)
        job_queue = job&.dig(:job_queue)
Severity: Minor
Found in lib/gems/baw-workers/lib/baw_workers/mail/mailer.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method error_notification has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def error_notification(to, from, job, error)
        raise ArgumentError, "Error is not a ruby error object #{error.inspect}." unless error.is_a?(StandardError)
        raise ArgumentError, "From is not a string #{from.inspect}." unless from.is_a?(String)
        raise ArgumentError, "To is not a string or Array #{to.inspect}." unless to.is_a?(String) || to.is_a?(Array)
        raise ArgumentError, "Job is not a hash #{job.inspect}." unless job.is_a?(Hash)
Severity: Minor
Found in lib/gems/baw-workers/lib/baw_workers/mail/mailer.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status